Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

2019-07-13 Thread Brian Masney
On Sat, Jul 13, 2019 at 01:26:45PM +0200, Luca Weiss wrote: > Hi Brian, > how about something like that (formatting is surely broken because I'm not > sending this with git-send-email^^)? > > I'd says this should be work fine with all devices as all modes are defined > in > the device-specific

Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

2019-07-13 Thread Luca Weiss
Hi Brian, how about something like that (formatting is surely broken because I'm not sending this with git-send-email^^)? I'd says this should be work fine with all devices as all modes are defined in the device-specific dts but the reg and offset values are in the board dts. Should I also add

Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

2019-06-21 Thread Brian Masney
On Fri, Jun 21, 2019 at 09:25:17PM +0200, Luca Weiss wrote: > On Freitag, 21. Juni 2019 02:01:22 CEST you wrote: > > I think that it makes sense to put this snippet in qcom-msm8974.dtsi > > with a status of disabled, and then enable it in > > qcom-msm8974-fairphone-fp2.dts like so: > > > > imem@fe

Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

2019-06-21 Thread Luca Weiss
On Freitag, 21. Juni 2019 02:01:22 CEST you wrote: > I think that it makes sense to put this snippet in qcom-msm8974.dtsi > with a status of disabled, and then enable it in > qcom-msm8974-fairphone-fp2.dts like so: > > imem@fe805000 { > status = "ok"; > }; Do you want me to put the whole no

Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

2019-06-20 Thread Brian Masney
Hi Luca, On Fri, Jun 21, 2019 at 12:58:24AM +0200, Luca Weiss wrote: > This enables userspace to signal the bootloader to go into the > bootloader or recovery mode. > > The magic values can be found in both the downstream kernel and the LK > kernel (bootloader). > > Signed-off-by: Luca Weiss >

[PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

2019-06-20 Thread Luca Weiss
This enables userspace to signal the bootloader to go into the bootloader or recovery mode. The magic values can be found in both the downstream kernel and the LK kernel (bootloader). Signed-off-by: Luca Weiss --- Sidenote: Why are there no userspace tools to be found that support this? Anyways,