Re: [PATCH] ARM: dts: sunxi: Explicitly enable pull-ups for MMC pins

2016-11-18 Thread Linus Walleij
[Notice this reply has little to do with the patch in question: I think it should be applied. I just want to involve some MMC/SD people here] On Thu, Nov 17, 2016 at 9:57 PM, wrote: > On 2016-11-17 10:34, Chen-Yu Tsai wrote: >> >> Given that MMC starts in open-drain mode and the pull-ups are req

Re: [PATCH] ARM: dts: sunxi: Explicitly enable pull-ups for MMC pins

2016-11-17 Thread klaus . goger
On 2016-11-17 10:34, Chen-Yu Tsai wrote: Given that MMC starts in open-drain mode and the pull-ups are required, it's best to enable it for all the pin settings. It's even more complicated than that with MMC. It starts in open-drain mode for CMD during initialization but changes to push-pull a

Re: [PATCH] ARM: dts: sunxi: Explicitly enable pull-ups for MMC pins

2016-11-17 Thread Maxime Ripard
On Thu, Nov 17, 2016 at 05:34:38PM +0800, Chen-Yu Tsai wrote: > In the past, all the MMC pins had > > allwinner,pull = ; > > which was actually a no-op. We were relying on U-boot to set the bias > pull up for us. These properties were removed as part of the fix up to > actually support no b

[PATCH] ARM: dts: sunxi: Explicitly enable pull-ups for MMC pins

2016-11-17 Thread Chen-Yu Tsai
In the past, all the MMC pins had allwinner,pull = ; which was actually a no-op. We were relying on U-boot to set the bias pull up for us. These properties were removed as part of the fix up to actually support no bias on the pins. During the transition some boards experienced regular MMC