Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-24 Thread Uwe Kleine-König
Hello, On Sat, May 24, 2014 at 01:05:00PM -0700, Greg Kroah-Hartman wrote: > Please feel free to break it up as asked for and I'll be glad to > consider it then. ack Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions |

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-24 Thread Greg Kroah-Hartman
On Sat, May 24, 2014 at 05:22:00PM +0200, Emil Goode wrote: > Hello Uwe and Greg, > > > You'd do a better deed if you picked up > > http://thread.gmane.org/gmane.linux.kernel/1613364/focus=1635995 > > Since there is nothing wrong with the last version of the patch in > the above thread, I feel

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-24 Thread Emil Goode
Hello Uwe and Greg, > You'd do a better deed if you picked up > http://thread.gmane.org/gmane.linux.kernel/1613364/focus=1635995 Since there is nothing wrong with the last version of the patch in the above thread, I feel strange about picking it up and just splitting it into two patches. However

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-24 Thread Emil Goode
Hello Uwe and Greg, You'd do a better deed if you picked up http://thread.gmane.org/gmane.linux.kernel/1613364/focus=1635995 Since there is nothing wrong with the last version of the patch in the above thread, I feel strange about picking it up and just splitting it into two patches. However

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-24 Thread Greg Kroah-Hartman
On Sat, May 24, 2014 at 05:22:00PM +0200, Emil Goode wrote: Hello Uwe and Greg, You'd do a better deed if you picked up http://thread.gmane.org/gmane.linux.kernel/1613364/focus=1635995 Since there is nothing wrong with the last version of the patch in the above thread, I feel strange

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-24 Thread Uwe Kleine-König
Hello, On Sat, May 24, 2014 at 01:05:00PM -0700, Greg Kroah-Hartman wrote: Please feel free to break it up as asked for and I'll be glad to consider it then. ack Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions |

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-23 Thread Philippe Rétornaz
Hi Uwe Le 22/05/2014 20:10, Uwe Kleine-König a écrit : [...] Today all imx machines should get their devices from an oftree, so the various functions to add devices started to bitrot. Moreover there is no reason to remove a device once it was successfully added. Note that

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-23 Thread Philippe Rétornaz
Hi Uwe Le 22/05/2014 20:10, Uwe Kleine-König a écrit : [...] Today all imx machines should get their devices from an oftree, so the various functions to add devices started to bitrot. Moreover there is no reason to remove a device once it was successfully added. Note that

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-22 Thread Dan Carpenter
On Thu, May 22, 2014 at 07:51:19PM +0200, Emil Goode wrote: > We forgot to free pdev->dev.dma_mask on error after > having called the imx_alloc_mx3_camera function. > This patch introduces the imx_free_mx3_camera function > that adds the missing kfree call and is practical for > future usage with

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-22 Thread Emil Goode
Hello Uwe, On Thu, May 22, 2014 at 08:10:24PM +0200, Uwe Kleine-König wrote: > Hello Emil, > > On Thu, May 22, 2014 at 07:51:19PM +0200, Emil Goode wrote: > > We forgot to free pdev->dev.dma_mask on error after > > having called the imx_alloc_mx3_camera function. > > This patch introduces the

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-22 Thread Uwe Kleine-König
Hello Emil, On Thu, May 22, 2014 at 07:51:19PM +0200, Emil Goode wrote: > We forgot to free pdev->dev.dma_mask on error after > having called the imx_alloc_mx3_camera function. > This patch introduces the imx_free_mx3_camera function > that adds the missing kfree call and is practical for >

[PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-22 Thread Emil Goode
We forgot to free pdev->dev.dma_mask on error after having called the imx_alloc_mx3_camera function. This patch introduces the imx_free_mx3_camera function that adds the missing kfree call and is practical for future usage with imx_alloc_mx3_camera(). Signed-off-by: Emil Goode ---

[PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-22 Thread Emil Goode
We forgot to free pdev-dev.dma_mask on error after having called the imx_alloc_mx3_camera function. This patch introduces the imx_free_mx3_camera function that adds the missing kfree call and is practical for future usage with imx_alloc_mx3_camera(). Signed-off-by: Emil Goode emilgo...@gmail.com

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-22 Thread Uwe Kleine-König
Hello Emil, On Thu, May 22, 2014 at 07:51:19PM +0200, Emil Goode wrote: We forgot to free pdev-dev.dma_mask on error after having called the imx_alloc_mx3_camera function. This patch introduces the imx_free_mx3_camera function that adds the missing kfree call and is practical for future

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-22 Thread Emil Goode
Hello Uwe, On Thu, May 22, 2014 at 08:10:24PM +0200, Uwe Kleine-König wrote: Hello Emil, On Thu, May 22, 2014 at 07:51:19PM +0200, Emil Goode wrote: We forgot to free pdev-dev.dma_mask on error after having called the imx_alloc_mx3_camera function. This patch introduces the

Re: [PATCH] ARM: imx: introduce function imx_free_mx3_camera

2014-05-22 Thread Dan Carpenter
On Thu, May 22, 2014 at 07:51:19PM +0200, Emil Goode wrote: We forgot to free pdev-dev.dma_mask on error after having called the imx_alloc_mx3_camera function. This patch introduces the imx_free_mx3_camera function that adds the missing kfree call and is practical for future usage with