Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

2018-11-01 Thread Kees Cook
On Thu, Nov 1, 2018 at 7:41 AM, Masami Hiramatsu wrote: > On Tue, 30 Oct 2018 13:40:27 -0400 > William Cohen wrote: > >> On 10/22/18 5:30 AM, Kees Cook wrote: >> > The arm compiler internally interprets an inline assembly label >> > as an unsigned long value, not a pointer. As a result, under >>

Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

2018-11-01 Thread Masami Hiramatsu
On Tue, 30 Oct 2018 13:40:27 -0400 William Cohen wrote: > On 10/22/18 5:30 AM, Kees Cook wrote: > > The arm compiler internally interprets an inline assembly label > > as an unsigned long value, not a pointer. As a result, under > > CONFIG_FORTIFY_SOURCE, the size of the array pointed to by an ad

Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

2018-10-30 Thread William Cohen
On 10/22/18 5:30 AM, Kees Cook wrote: > The arm compiler internally interprets an inline assembly label > as an unsigned long value, not a pointer. As a result, under > CONFIG_FORTIFY_SOURCE, the size of the array pointed to by an address > of a label is 4 bytes, which was tripping the runtime chec

Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

2018-10-22 Thread Masami Hiramatsu
On Mon, 22 Oct 2018 02:30:23 -0700 Kees Cook wrote: > The arm compiler internally interprets an inline assembly label > as an unsigned long value, not a pointer. As a result, under > CONFIG_FORTIFY_SOURCE, the size of the array pointed to by an address > of a label is 4 bytes, which was tripping

Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

2018-10-22 Thread Laura Abbott
On 10/22/2018 02:30 AM, Kees Cook wrote: The arm compiler internally interprets an inline assembly label as an unsigned long value, not a pointer. As a result, under CONFIG_FORTIFY_SOURCE, the size of the array pointed to by an address of a label is 4 bytes, which was tripping the runtime checks.

[PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

2018-10-22 Thread Kees Cook
The arm compiler internally interprets an inline assembly label as an unsigned long value, not a pointer. As a result, under CONFIG_FORTIFY_SOURCE, the size of the array pointed to by an address of a label is 4 bytes, which was tripping the runtime checks. Instead, we can just cast the label (as do