Re: [PATCH] ARM: ks8695: fix __initdata annotation

2016-02-26 Thread Arnd Bergmann
On Tuesday 09 February 2016 09:36:00 Greg Ungerer wrote: > On 09/02/16 00:24, Arnd Bergmann wrote: > > Clang complains about the __initdata section attribute being in the > > wrong place in two files of ks8695: > > > > arch/arm/mach-ks8695/cpu.c:37:31: error: '__section__' attribute only > > appl

Re: [PATCH] ARM: ks8695: fix __initdata annotation

2016-02-09 Thread Arnd Bergmann
On Tuesday 09 February 2016 12:36:24 Uwe Kleine-König wrote: > Having the attribute list after the declarator isn't recommended as > explicit as I remember having read it somewhere in the gcc docs. > > info gcc "Attribute Syntax" > > has: > > An attribute specifier list may appe

Re: [PATCH] ARM: ks8695: fix __initdata annotation

2016-02-09 Thread Uwe Kleine-König
Hello Arnd, On Tue, Feb 09, 2016 at 12:14:15PM +0100, Arnd Bergmann wrote: > On Tuesday 09 February 2016 10:00:30 Uwe Kleine-König wrote: > > > diff --git a/arch/arm/mach-ks8695/board-og.c > > > b/arch/arm/mach-ks8695/board-og.c > > > index 1f4f2f4f25bb..fa1a7c2ca2bb 100644 > > > --- a/arch/arm/m

Re: [PATCH] ARM: ks8695: fix __initdata annotation

2016-02-09 Thread Arnd Bergmann
On Tuesday 09 February 2016 10:00:30 Uwe Kleine-König wrote: > > diff --git a/arch/arm/mach-ks8695/board-og.c > > b/arch/arm/mach-ks8695/board-og.c > > index 1f4f2f4f25bb..fa1a7c2ca2bb 100644 > > --- a/arch/arm/mach-ks8695/board-og.c > > +++ b/arch/arm/mach-ks8695/board-og.c > > @@ -80,7 +80,7 @@

Re: [PATCH] ARM: ks8695: fix __initdata annotation

2016-02-09 Thread Uwe Kleine-König
On Mon, Feb 08, 2016 at 03:24:57PM +0100, Arnd Bergmann wrote: > Clang complains about the __initdata section attribute being in the > wrong place in two files of ks8695: > > arch/arm/mach-ks8695/cpu.c:37:31: error: '__section__' attribute only applies > to functions and global variables > arch/a

Re: [PATCH] ARM: ks8695: fix __initdata annotation

2016-02-08 Thread Greg Ungerer
On 09/02/16 00:24, Arnd Bergmann wrote: > Clang complains about the __initdata section attribute being in the > wrong place in two files of ks8695: > > arch/arm/mach-ks8695/cpu.c:37:31: error: '__section__' attribute only applies > to functions and global variables > arch/arm/mach-ks8695/board-og

[PATCH] ARM: ks8695: fix __initdata annotation

2016-02-08 Thread Arnd Bergmann
Clang complains about the __initdata section attribute being in the wrong place in two files of ks8695: arch/arm/mach-ks8695/cpu.c:37:31: error: '__section__' attribute only applies to functions and global variables arch/arm/mach-ks8695/board-og.c:83:31: error: '__section__' attribute only appli