Re: [PATCH] ARM: mmp: replace NO_IRQ

2016-09-08 Thread Arnd Bergmann
On Tuesday, September 6, 2016 10:22:06 PM CEST Russell King - ARM Linux wrote: > oak uses NCR5380. NCR5380 is shared across multiple architectures > which have a random selection of NO_IRQ defined as 0 or -1. To > convert this without regression takes a multi-step process: > > 1. Verify all arch

Re: [PATCH] ARM: mmp: replace NO_IRQ

2016-09-06 Thread Russell King - ARM Linux
On Tue, Sep 06, 2016 at 01:03:42PM -0700, Linus Torvalds wrote: > On Tue, Sep 6, 2016 at 12:44 PM, Russell King - ARM Linux > wrote: > > > > My point still stands though. Merely hiding it doesn't make the problem > > go away - it's just the same problem but now it won't be as visible, and > > as

Re: [PATCH] ARM: mmp: replace NO_IRQ

2016-09-06 Thread Russell King - ARM Linux
On Tue, Sep 06, 2016 at 10:19:18PM +0200, Arnd Bergmann wrote: > The patch was correct, the only problem that you pointed out already > was that it needs to be applied on top of your patch. I didn't > check when the file was touched the last time but only looked at > the current state in linux-next

Re: [PATCH] ARM: mmp: replace NO_IRQ

2016-09-06 Thread Arnd Bergmann
On Tuesday, September 6, 2016 8:44:43 PM CEST Russell King - ARM Linux wrote: > On Tue, Sep 06, 2016 at 09:28:17PM +0200, Arnd Bergmann wrote: > > On Tuesday, September 6, 2016 3:24:42 PM CEST Russell King - ARM Linux > > wrote: > > > On Tue, Sep 06, 2016 at 04:07:56PM +0200, Arnd Bergmann wrote:

Re: [PATCH] ARM: mmp: replace NO_IRQ

2016-09-06 Thread Linus Torvalds
On Tue, Sep 6, 2016 at 12:44 PM, Russell King - ARM Linux wrote: > > My point still stands though. Merely hiding it doesn't make the problem > go away - it's just the same problem but now it won't be as visible, and > as such it'll probably never get resolved. How much of a legacy thing is this?

Re: [PATCH] ARM: mmp: replace NO_IRQ

2016-09-06 Thread Russell King - ARM Linux
On Tue, Sep 06, 2016 at 09:28:17PM +0200, Arnd Bergmann wrote: > On Tuesday, September 6, 2016 3:24:42 PM CEST Russell King - ARM Linux wrote: > > On Tue, Sep 06, 2016 at 04:07:56PM +0200, Arnd Bergmann wrote: > > > The mmp platform has its own definitions with the old NO_IRQ meaning, > > > but com

Re: [PATCH] ARM: mmp: replace NO_IRQ

2016-09-06 Thread Arnd Bergmann
On Tuesday, September 6, 2016 3:24:42 PM CEST Russell King - ARM Linux wrote: > On Tue, Sep 06, 2016 at 04:07:56PM +0200, Arnd Bergmann wrote: > > The mmp platform has its own definitions with the old NO_IRQ meaning, > > but compares against the global NO_IRQ macro that we should have > > removed l

Re: [PATCH] ARM: mmp: replace NO_IRQ

2016-09-06 Thread Russell King - ARM Linux
On Tue, Sep 06, 2016 at 04:07:56PM +0200, Arnd Bergmann wrote: > The mmp platform has its own definitions with the old NO_IRQ meaning, > but compares against the global NO_IRQ macro that we should have > removed long ago. > > The specific usage in arch/arm/mach-mmp/devices.c is awkward, but > fixi

[PATCH] ARM: mmp: replace NO_IRQ

2016-09-06 Thread Arnd Bergmann
The mmp platform has its own definitions with the old NO_IRQ meaning, but compares against the global NO_IRQ macro that we should have removed long ago. The specific usage in arch/arm/mach-mmp/devices.c is awkward, but fixing it properly would require a larger scale rewrite of the entire file, or