Re: [PATCH] ARM: omap1: fix irq setup

2020-06-16 Thread Tony Lindgren
* afzal mohammed [200505 14:31]: > Hi, > > On Tue, May 05, 2020 at 04:13:48PM +0200, Arnd Bergmann wrote: > > > A recent cleanup introduced a bug on any omap1 machine that has > > no wakeup IRQ, i.e. omap15xx: > > > Move this code into a separate function to deal with it cleanly. > > > > Fixes

Re: [PATCH] ARM: omap1: fix irq setup

2020-05-05 Thread Tony Lindgren
* afzal mohammed [200505 14:31]: > Hi, > > On Tue, May 05, 2020 at 04:13:48PM +0200, Arnd Bergmann wrote: > > > A recent cleanup introduced a bug on any omap1 machine that has > > no wakeup IRQ, i.e. omap15xx: > > > Move this code into a separate function to deal with it cleanly. > > > > Fixes

Re: [PATCH] ARM: omap1: fix irq setup

2020-05-05 Thread afzal mohammed
Hi, On Tue, May 05, 2020 at 04:13:48PM +0200, Arnd Bergmann wrote: > A recent cleanup introduced a bug on any omap1 machine that has > no wakeup IRQ, i.e. omap15xx: > Move this code into a separate function to deal with it cleanly. > > Fixes: b75ca5217743 ("ARM: OMAP: replace setup_irq() by req

[PATCH] ARM: omap1: fix irq setup

2020-05-05 Thread Arnd Bergmann
A recent cleanup introduced a bug on any omap1 machine that has no wakeup IRQ, i.e. omap15xx: arch/arm/mach-omap1/pm.c:656:11: error: variable 'irq' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] else if (cpu_is_omap16xx()) ^~~~