Re: [PATCH] ARM: omap2: fix omap5_realtime_timer_init definition

2020-05-29 Thread Tony Lindgren
* Arnd Bergmann [200529 21:41]: > On Fri, May 29, 2020 at 11:14 PM Tony Lindgren wrote: > > * Arnd Bergmann [200529 21:09]: > > > > > > #ifdef CONFIG_SOC_HAS_REALTIME_COUNTER > > > extern void omap5_realtime_timer_init(void); > > > #else > > > static inline void omap5_realtime_timer_init(void) >

Re: [PATCH] ARM: omap2: fix omap5_realtime_timer_init definition

2020-05-29 Thread Arnd Bergmann
On Fri, May 29, 2020 at 11:14 PM Tony Lindgren wrote: > * Arnd Bergmann [200529 21:09]: > > > > #ifdef CONFIG_SOC_HAS_REALTIME_COUNTER > > extern void omap5_realtime_timer_init(void); > > #else > > static inline void omap5_realtime_timer_init(void) > > { > > } > > #endif > > > > In fact, the inli

Re: [PATCH] ARM: omap2: fix omap5_realtime_timer_init definition

2020-05-29 Thread Tony Lindgren
* Arnd Bergmann [200529 21:09]: > On Fri, May 29, 2020 at 10:44 PM Tony Lindgren wrote: > > > > * Arnd Bergmann [200529 20:18]: > > > There is one more regression introduced by the last build fix: > > > > Argh.. I did run make randconfig for like 10 builds > > after the last fix. > > > > > Addre

Re: [PATCH] ARM: omap2: fix omap5_realtime_timer_init definition

2020-05-29 Thread Arnd Bergmann
On Fri, May 29, 2020 at 10:44 PM Tony Lindgren wrote: > > * Arnd Bergmann [200529 20:18]: > > There is one more regression introduced by the last build fix: > > Argh.. I did run make randconfig for like 10 builds > after the last fix. > > > Address this by removing the now obsolete #ifdefs in tha

Re: [PATCH] ARM: omap2: fix omap5_realtime_timer_init definition

2020-05-29 Thread Tony Lindgren
* Arnd Bergmann [200529 20:18]: > There is one more regression introduced by the last build fix: Argh.. I did run make randconfig for like 10 builds after the last fix. > arch/arm/mach-omap2/timer.c:170:6: error: attribute declaration must precede > definition [-Werror,-Wignored-attributes] > v

[PATCH] ARM: omap2: fix omap5_realtime_timer_init definition

2020-05-29 Thread Arnd Bergmann
There is one more regression introduced by the last build fix: arch/arm/mach-omap2/timer.c:170:6: error: attribute declaration must precede definition [-Werror,-Wignored-attributes] void __init omap5_realtime_timer_init(void) ^ arch/arm/mach-omap2/common.h:118:20: note: previous definition i