Re: [PATCH] ARM: perf: Don't sleep while atomic when enabling per-cpu interrupts

2014-09-10 Thread Stephen Boyd
On 09/10/14 11:21, Will Deacon wrote: > On Tue, Sep 09, 2014 at 06:54:45PM +0100, Stephen Boyd wrote: > >> Here's the interdiff. Is there a reason arm64 casts data to an unsigned >> int pointer when what's passed is an int pointer? > There has to be a cast to something because data is a void *. > e

Re: [PATCH] ARM: perf: Don't sleep while atomic when enabling per-cpu interrupts

2014-09-10 Thread Will Deacon
On Tue, Sep 09, 2014 at 06:54:45PM +0100, Stephen Boyd wrote: > On 09/09/14 04:39, Will Deacon wrote: > > It's interesting that arm64 isn't affected by this problem, since we don't > > update the active_irqs mask for PPIs there and consequently just pass the > > irq instead of the cpu_pmu. I can't

Re: [PATCH] ARM: perf: Don't sleep while atomic when enabling per-cpu interrupts

2014-09-09 Thread Stephen Boyd
On 09/09/14 04:39, Will Deacon wrote: > It's interesting that arm64 isn't affected by this problem, since we don't > update the active_irqs mask for PPIs there and consequently just pass the > irq instead of the cpu_pmu. I can't see why we actually need to update the > active_irqs mask for arch/arm

Re: [PATCH] ARM: perf: Don't sleep while atomic when enabling per-cpu interrupts

2014-09-09 Thread Will Deacon
Hi Stephen, On Mon, Sep 08, 2014 at 07:26:54PM +0100, Stephen Boyd wrote: > Rob Clark reports a sleeping while atomic bug when using perf. > > BUG: sleeping function called from invalid context at > ../kernel/locking/mutex.c:583 > in_atomic(): 1, irqs_disabled(): 128, pid: 0, name: swapper/0 > -

[PATCH] ARM: perf: Don't sleep while atomic when enabling per-cpu interrupts

2014-09-08 Thread Stephen Boyd
Rob Clark reports a sleeping while atomic bug when using perf. BUG: sleeping function called from invalid context at ../kernel/locking/mutex.c:583 in_atomic(): 1, irqs_disabled(): 128, pid: 0, name: swapper/0 [ cut here ] WARNING: CPU: 2 PID: 4828 at ../kernel/locking/mute