Re: [PATCH] ARM i.MX: Fix a kernel panic in i2c_imx_clk_notifier_call().

2018-12-17 Thread Peter Rosin
On 2018-12-17 10:12, Krzysztof Hałasa wrote: > 90ad2cbe88c22d0215225ab9594eeead0eb24fde changed the i.MX I2C bus driver This reference should ideally be in a fixes-tag, below... > to use a notifier whenever the base clock ("ipg" - 66 MHz peripheral > clock) rate changes. > > Unfortunately one ca

Re: [PATCH] ARM i.MX: Fix a kernel panic in i2c_imx_clk_notifier_call().

2018-12-17 Thread Uwe Kleine-König
On Mon, Dec 17, 2018 at 10:12:14AM +0100, Krzysztof Hałasa wrote: > 90ad2cbe88c22d0215225ab9594eeead0eb24fde changed the i.MX I2C bus driver > to use a notifier whenever the base clock ("ipg" - 66 MHz peripheral > clock) rate changes. > > Unfortunately one can't use the container_of() macro this w

[PATCH] ARM i.MX: Fix a kernel panic in i2c_imx_clk_notifier_call().

2018-12-17 Thread Krzysztof Hałasa
90ad2cbe88c22d0215225ab9594eeead0eb24fde changed the i.MX I2C bus driver to use a notifier whenever the base clock ("ipg" - 66 MHz peripheral clock) rate changes. Unfortunately one can't use the container_of() macro this way - the first argument has to point to a member of the bigger struct (last

Re: [PATCH] ARM i.MX: Fix a kernel panic in i2c_imx_clk_notifier_call().

2018-12-03 Thread Krzysztof Hałasa
Hi Fabio, Fabio Estevam writes: > Please provide a commit log, giving some context to your fix. Well, I hope Lucas could add something here. I am uncertain how it was supposed to work, the ndata->clk (the pointer, not the clk pointed by it) can't be at the same time a member of imx_i2c_struct,

Re: [PATCH] ARM i.MX: Fix a kernel panic in i2c_imx_clk_notifier_call().

2018-12-03 Thread Fabio Estevam
Hi Krzysztof, On Mon, Dec 3, 2018 at 9:13 AM Krzysztof Hałasa wrote: > > Signed-off-by: Krzysztof Halasa Please provide a commit log, giving some context to your fix. Is this a regression?

[PATCH] ARM i.MX: Fix a kernel panic in i2c_imx_clk_notifier_call().

2018-12-03 Thread Krzysztof Hałasa
Signed-off-by: Krzysztof Halasa --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -510,9 +510,9 @@ static int i2c_imx_clk_notifier_call(struct notifier_block *nb, unsigned long action, void *data) { struct clk_notifier_data *nd