Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-18 Thread Ingo Molnar
* Borislav Petkov wrote: > On Wed, Feb 18, 2015 at 09:19:01PM +0100, Ingo Molnar wrote: > > Absolutely, this is x86/urgent material, so no need to wait for -rc1 > > with it. > > Right, so I can start shuffling stuff to you tomorrow, > this patch is in one of the pull requests. I can drop it

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-18 Thread Borislav Petkov
On Wed, Feb 18, 2015 at 09:19:01PM +0100, Ingo Molnar wrote: > Absolutely, this is x86/urgent material, so no need to wait for -rc1 > with it. Right, so I can start shuffling stuff to you tomorrow, this patch is in one of the pull requests. I can drop it too if preferred. I'll let you guys

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-18 Thread Ingo Molnar
* Andrew Morton wrote: > On Wed, 18 Feb 2015 10:15:43 +0100 Borislav Petkov wrote: > > > CVE-2015-1593 > > > > > > Signed-off-by: Hector Marco-Gisbert > > > Signed-off-by: Ismael Ripoll > > > [kees: rebase, fix 80 char, clean up commit message, add test example, > > > cve] > > >

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-18 Thread Andrew Morton
On Wed, 18 Feb 2015 10:15:43 +0100 Borislav Petkov wrote: > > CVE-2015-1593 > > > > Signed-off-by: Hector Marco-Gisbert > > Signed-off-by: Ismael Ripoll > > [kees: rebase, fix 80 char, clean up commit message, add test example, cve] > > Signed-off-by: Kees Cook > > Cc: sta...@vger.kernel.org

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-18 Thread Borislav Petkov
On Sat, Feb 14, 2015 at 09:33:50AM -0800, Kees Cook wrote: > From: Hector Marco-Gisbert > > The issue is that the stack for processes is not properly randomized on 64 bit > architectures due to an integer overflow. > > The affected function is randomize_stack_top() in file "fs/binfmt_elf.c": >

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-18 Thread Borislav Petkov
On Sat, Feb 14, 2015 at 09:33:50AM -0800, Kees Cook wrote: From: Hector Marco-Gisbert hecma...@upv.es The issue is that the stack for processes is not properly randomized on 64 bit architectures due to an integer overflow. The affected function is randomize_stack_top() in file

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-18 Thread Ingo Molnar
* Andrew Morton a...@linux-foundation.org wrote: On Wed, 18 Feb 2015 10:15:43 +0100 Borislav Petkov b...@alien8.de wrote: CVE-2015-1593 Signed-off-by: Hector Marco-Gisbert hecma...@upv.es Signed-off-by: Ismael Ripoll irip...@upv.es [kees: rebase, fix 80 char, clean up commit

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-18 Thread Borislav Petkov
On Wed, Feb 18, 2015 at 09:19:01PM +0100, Ingo Molnar wrote: Absolutely, this is x86/urgent material, so no need to wait for -rc1 with it. Right, so I can start shuffling stuff to you tomorrow, this patch is in one of the pull requests. I can drop it too if preferred. I'll let you guys decide.

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-18 Thread Ingo Molnar
* Borislav Petkov b...@alien8.de wrote: On Wed, Feb 18, 2015 at 09:19:01PM +0100, Ingo Molnar wrote: Absolutely, this is x86/urgent material, so no need to wait for -rc1 with it. Right, so I can start shuffling stuff to you tomorrow, this patch is in one of the pull requests. I can

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-18 Thread Andrew Morton
On Wed, 18 Feb 2015 10:15:43 +0100 Borislav Petkov b...@alien8.de wrote: CVE-2015-1593 Signed-off-by: Hector Marco-Gisbert hecma...@upv.es Signed-off-by: Ismael Ripoll irip...@upv.es [kees: rebase, fix 80 char, clean up commit message, add test example, cve] Signed-off-by: Kees Cook

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-17 Thread Kees Cook
On Mon, Feb 16, 2015 at 12:49 PM, Andy Lutomirski wrote: > On 02/14/2015 09:33 AM, Kees Cook wrote: >> >> From: Hector Marco-Gisbert >> >> The issue is that the stack for processes is not properly randomized on 64 >> bit >> architectures due to an integer overflow. >> >> The affected function is

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-17 Thread Kees Cook
On Mon, Feb 16, 2015 at 12:49 PM, Andy Lutomirski l...@amacapital.net wrote: On 02/14/2015 09:33 AM, Kees Cook wrote: From: Hector Marco-Gisbert hecma...@upv.es The issue is that the stack for processes is not properly randomized on 64 bit architectures due to an integer overflow. The

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-16 Thread Andy Lutomirski
On 02/14/2015 09:33 AM, Kees Cook wrote: From: Hector Marco-Gisbert The issue is that the stack for processes is not properly randomized on 64 bit architectures due to an integer overflow. The affected function is randomize_stack_top() in file "fs/binfmt_elf.c": static unsigned long

Re: [PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-16 Thread Andy Lutomirski
On 02/14/2015 09:33 AM, Kees Cook wrote: From: Hector Marco-Gisbert hecma...@upv.es The issue is that the stack for processes is not properly randomized on 64 bit architectures due to an integer overflow. The affected function is randomize_stack_top() in file fs/binfmt_elf.c: static unsigned

[PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-14 Thread Kees Cook
From: Hector Marco-Gisbert The issue is that the stack for processes is not properly randomized on 64 bit architectures due to an integer overflow. The affected function is randomize_stack_top() in file "fs/binfmt_elf.c": static unsigned long randomize_stack_top(unsigned long stack_top) {

[PATCH] ASLR: fix stack randomization on 64-bit systems

2015-02-14 Thread Kees Cook
From: Hector Marco-Gisbert hecma...@upv.es The issue is that the stack for processes is not properly randomized on 64 bit architectures due to an integer overflow. The affected function is randomize_stack_top() in file fs/binfmt_elf.c: static unsigned long randomize_stack_top(unsigned long