Re: [PATCH] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function

2020-05-21 Thread Pierre-Louis Bossart
On 5/21/20 9:43 AM, Łukasz Majczak wrote: Pierre Sorry, I didn't get it for the first time, you are suggesting to not use DMIC01 as it is used by PCH-attached dmics by other drivers. Yes, it's confusing and it also took me time during the initial reviews of this driver to figure out it's d

Re: [PATCH] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function

2020-05-21 Thread Łukasz Majczak
Pierre Sorry, I didn't get it for the first time, you are suggesting to not use DMIC01 as it is used by PCH-attached dmics by other drivers. Best regards, Lukasz czw., 21 maj 2020 o 16:36 Łukasz Majczak napisał(a): > > Yes, my bad > it should be: > + { "codec1_in", NULL, "DMIC01 Rx" }, >

Re: [PATCH] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function

2020-05-21 Thread Łukasz Majczak
Yes, my bad it should be: + { "codec1_in", NULL, "DMIC01 Rx" }, + { "DMIC01 Rx", NULL, "AIF1 Capture" }, The whole idea of taking the mic for SSP0 definition is that each BE should have its own fixup. Before there was one fixup function, which checked inside which BE is connected to wh

Re: [PATCH] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function

2020-05-21 Thread Pierre-Louis Bossart
On 5/21/20 8:47 AM, Lukasz Majczak wrote: Split be_hw_params_fixup function for different codecs as current common function, leads to crash while trying to get snd_soc_dpcm with container_of() macro in kabylake_ssp_fixup(). The crash call path looks as below: soc_pcm_hw_params() snd_soc_dai_hw

[PATCH] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function

2020-05-21 Thread Lukasz Majczak
Split be_hw_params_fixup function for different codecs as current common function, leads to crash while trying to get snd_soc_dpcm with container_of() macro in kabylake_ssp_fixup(). The crash call path looks as below: soc_pcm_hw_params() snd_soc_dai_hw_params(codec_dai, substream, &codec_params); r

Re: [PATCH] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function

2020-05-14 Thread Guenter Roeck
On Thu, May 14, 2020 at 5:47 AM Pierre-Louis Bossart wrote: > > > > On 5/13/20 2:20 PM, Lukasz Majczak wrote: > > Split be_hw_params_fixup function for different codecs as current common > > function, leads to crash while trying to get snd_soc_dpcm with > > container_of() macro in kabylake_ssp_fix

Re: [PATCH] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function

2020-05-14 Thread Pierre-Louis Bossart
On 5/13/20 2:20 PM, Lukasz Majczak wrote: Split be_hw_params_fixup function for different codecs as current common function, leads to crash while trying to get snd_soc_dpcm with container_of() macro in kabylake_ssp_fixup(). The crash call path looks as below: soc_pcm_hw_params() snd_soc_dai_hw

[PATCH] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function

2020-05-13 Thread Lukasz Majczak
Split be_hw_params_fixup function for different codecs as current common function, leads to crash while trying to get snd_soc_dpcm with container_of() macro in kabylake_ssp_fixup(). The crash call path looks as below: soc_pcm_hw_params() snd_soc_dai_hw_params(codec_dai, substream, &codec_params); r