Re: [alsa-devel] [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 19:56:51 +0200, Pierre-Louis Bossart wrote: > > > Yes, that would work. OTOH, I see no merit to build an extra module > for nocodec. nocodec.c can be built together with sof-core stuff. > >> > >> the module has its benefits. Today nocodec includes all possible

Re: [alsa-devel] [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Pierre-Louis Bossart
Yes, that would work. OTOH, I see no merit to build an extra module for nocodec. nocodec.c can be built together with sof-core stuff. the module has its benefits. Today nocodec includes all possible DAIs, I wanted to add module parameters to restrict things a bit for tests/debug. It'll be

Re: [alsa-devel] [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 17:29:58 +0200, Pierre-Louis Bossart wrote: > > > > On 5/10/19 8:56 AM, Takashi Iwai wrote: > > On Fri, 10 May 2019 15:41:10 +0200, > > Takashi Iwai wrote: > >> > >> On Fri, 10 May 2019 15:34:03 +0200, > >> Pierre-Louis Bossart wrote: > >>> > >>> On 5/10/19 8:04 AM, Takashi

Re: [alsa-devel] [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Pierre-Louis Bossart
On 5/10/19 8:56 AM, Takashi Iwai wrote: On Fri, 10 May 2019 15:41:10 +0200, Takashi Iwai wrote: On Fri, 10 May 2019 15:34:03 +0200, Pierre-Louis Bossart wrote: On 5/10/19 8:04 AM, Takashi Iwai wrote: On Fri, 10 May 2019 14:56:29 +0200, Pierre-Louis Bossart wrote: On 5/10/19 2:12 AM,

Re: [alsa-devel] [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 15:41:10 +0200, Takashi Iwai wrote: > > On Fri, 10 May 2019 15:34:03 +0200, > Pierre-Louis Bossart wrote: > > > > On 5/10/19 8:04 AM, Takashi Iwai wrote: > > > On Fri, 10 May 2019 14:56:29 +0200, > > > Pierre-Louis Bossart wrote: > > >> > > >> On 5/10/19 2:12 AM, Takashi Iwai

Re: [alsa-devel] [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 15:34:03 +0200, Pierre-Louis Bossart wrote: > > On 5/10/19 8:04 AM, Takashi Iwai wrote: > > On Fri, 10 May 2019 14:56:29 +0200, > > Pierre-Louis Bossart wrote: > >> > >> On 5/10/19 2:12 AM, Takashi Iwai wrote: > >>> On Fri, 10 May 2019 04:36:57 +0200, > >>> YueHaibing wrote: >

Re: [alsa-devel] [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Pierre-Louis Bossart
On 5/10/19 8:04 AM, Takashi Iwai wrote: On Fri, 10 May 2019 14:56:29 +0200, Pierre-Louis Bossart wrote: On 5/10/19 2:12 AM, Takashi Iwai wrote: On Fri, 10 May 2019 04:36:57 +0200, YueHaibing wrote: Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m sound/soc/sof/core.o: In function

Re: [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread YueHaibing
On 2019/5/10 15:12, Takashi Iwai wrote: > On Fri, 10 May 2019 04:36:57 +0200, > YueHaibing wrote: >> >> Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m >> >> sound/soc/sof/core.o: In function `snd_sof_device_probe': >> core.c:(.text+0x4af): undefined reference to `sof_nocodec_setup' >> >>

Re: [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 14:56:29 +0200, Pierre-Louis Bossart wrote: > > On 5/10/19 2:12 AM, Takashi Iwai wrote: > > On Fri, 10 May 2019 04:36:57 +0200, > > YueHaibing wrote: > >> > >> Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m > >> > >> sound/soc/sof/core.o: In function

Re: [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Pierre-Louis Bossart
On 5/10/19 2:12 AM, Takashi Iwai wrote: On Fri, 10 May 2019 04:36:57 +0200, YueHaibing wrote: Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m sound/soc/sof/core.o: In function `snd_sof_device_probe': core.c:(.text+0x4af): undefined reference to `sof_nocodec_setup' Change

Re: [PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-10 Thread Takashi Iwai
On Fri, 10 May 2019 04:36:57 +0200, YueHaibing wrote: > > Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m > > sound/soc/sof/core.o: In function `snd_sof_device_probe': > core.c:(.text+0x4af): undefined reference to `sof_nocodec_setup' > > Change SND_SOC_SOF_NOCODEC to bool to fix this. >

[PATCH] ASoC: SOF: Fix build error with CONFIG_SND_SOC_SOF_NOCODEC=m

2019-05-09 Thread YueHaibing
Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m sound/soc/sof/core.o: In function `snd_sof_device_probe': core.c:(.text+0x4af): undefined reference to `sof_nocodec_setup' Change SND_SOC_SOF_NOCODEC to bool to fix this. Reported-by: Hulk Robot Fixes: c16211d6226d ("ASoC: SOF: Add Sound