Re: [PATCH] ASoC: atmel: fix atmel_ssc_set_audio link failure

2019-10-02 Thread Mark Brown
On Tue, Oct 01, 2019 at 09:02:22PM +0200, Arnd Bergmann wrote: > On Tue, Oct 1, 2019 at 7:55 PM Mark Brown wrote: > > This doesn't apply against current code, please check and resend. > I looked at "git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git > for-next" > as well as the

Re: [PATCH] ASoC: atmel: fix atmel_ssc_set_audio link failure

2019-10-01 Thread Arnd Bergmann
On Tue, Oct 1, 2019 at 7:55 PM Mark Brown wrote: > > On Tue, Oct 01, 2019 at 04:20:55PM +0200, Arnd Bergmann wrote: > > The ssc audio driver can call into both pdc and dma backends. With the > > latest rework, the logic to do this in a safe way avoiding link errors > > was removed, bringing back

Re: [PATCH] ASoC: atmel: fix atmel_ssc_set_audio link failure

2019-10-01 Thread Mark Brown
On Tue, Oct 01, 2019 at 04:20:55PM +0200, Arnd Bergmann wrote: > The ssc audio driver can call into both pdc and dma backends. With the > latest rework, the logic to do this in a safe way avoiding link errors > was removed, bringing back link errors that were fixed long ago in commit >

Re: [PATCH] ASoC: atmel: fix atmel_ssc_set_audio link failure

2019-10-01 Thread Arnd Bergmann
On Tue, Oct 1, 2019 at 4:27 PM Alexandre Belloni wrote: > > -obj-$(CONFIG_SND_ATMEL_SOC_PDC) += snd-soc-atmel-pcm-pdc.o > > -obj-$(CONFIG_SND_ATMEL_SOC_DMA) += snd-soc-atmel-pcm-dma.o > > +# pdc and dma need to both be built-in if any user of > > +# ssc is built-in. > > +ifdef

Re: [PATCH] ASoC: atmel: fix atmel_ssc_set_audio link failure

2019-10-01 Thread Michał Mirosław
On Tue, Oct 01, 2019 at 04:20:55PM +0200, Arnd Bergmann wrote: > The ssc audio driver can call into both pdc and dma backends. With the > latest rework, the logic to do this in a safe way avoiding link errors > was removed, bringing back link errors that were fixed long ago in commit >

Re: [PATCH] ASoC: atmel: fix atmel_ssc_set_audio link failure

2019-10-01 Thread Alexandre Belloni
Hi, On 01/10/2019 16:20:55+0200, Arnd Bergmann wrote: > The ssc audio driver can call into both pdc and dma backends. With the > latest rework, the logic to do this in a safe way avoiding link errors > was removed, bringing back link errors that were fixed long ago in commit > 061981ff8cc8

[PATCH] ASoC: atmel: fix atmel_ssc_set_audio link failure

2019-10-01 Thread Arnd Bergmann
The ssc audio driver can call into both pdc and dma backends. With the latest rework, the logic to do this in a safe way avoiding link errors was removed, bringing back link errors that were fixed long ago in commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") such as