RE: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support

2019-09-27 Thread Lu, Brent
> > > > It's not only the mismatch but also the design limitation. According > > to the information from google, the board (samus) only uses two > > microphone so > > 3 or 4 channel recording are not supported. That's the reason we > > leverage the constraint from other machine driver (like > >

Re: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support

2019-09-12 Thread Pierre-Louis Bossart
On 9/12/19 1:00 AM, Lu, Brent wrote: The story is Chrome has a tool called alsa_conformance_test which runs capture or playback against a PCM port with all possible configurations (channel, format, rate) then measure if the sample rate is correct. Since the channel max number reported is 4, it

RE: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support

2019-09-12 Thread Lu, Brent
> > > > The story is Chrome has a tool called alsa_conformance_test which runs > > capture or playback against a PCM port with all possible > > configurations (channel, format, rate) then measure if the sample rate > > is correct. Since the channel max number reported is 4, it tests the > >

Re: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support

2019-09-10 Thread Pierre-Louis Bossart
I also don't see any case where we support 4 channels in any broadwell machine driver? It's the bdw-rt5650.c which only exists in chrome's 3.14 branch supporting Buddy project. They submitted the machine driver but not yet merged. https://patchwork.kernel.org/patch/11050985/ So again can

RE: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support

2019-09-10 Thread Lu, Brent
kernel.org; > yang@linux.intel.com; ti...@suse.com; liam.r.girdw...@linux.intel.com; > broo...@kernel.org; t...@linutronix.de > Subject: Re: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint > support > > Please don't top-post on public mailing lists. > > > We are

Re: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support

2019-09-09 Thread Pierre-Louis Bossart
Cezary ; liam.r.girdw...@linux.intel.com; yang@linux.intel.com; broo...@kernel.org; pe...@perex.cz; ti...@suse.com; kuninori.morimoto...@renesas.com; t...@linutronix.de; linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support On 9/5/19 8

RE: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support

2019-09-09 Thread Lu, Brent
rex.cz; ti...@suse.com; kuninori.morimoto...@renesas.com; t...@linutronix.de; linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support On 9/5/19 8:24 PM, Brent Lu wrote: > BDW boards using this machine driver supports only stereo capture an

Re: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support

2019-09-06 Thread Pierre-Louis Bossart
On 9/5/19 8:24 PM, Brent Lu wrote: BDW boards using this machine driver supports only stereo capture and playback. Implement a constraint to enforce it. Humm, can you clarify what problem/error this patch fixes? There are already constraints on the hsw_dais[] where the channels are stereo

[PATCH] ASoC: bdw-rt5677: channel constraint support

2019-09-05 Thread Brent Lu
BDW boards using this machine driver supports only stereo capture and playback. Implement a constraint to enforce it. Signed-off-by: Brent Lu --- sound/soc/intel/boards/bdw-rt5677.c | 33 + 1 file changed, 33 insertions(+) diff --git