Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-17 Thread Daniel Baluta
On Fri, Mar 12, 2021 at 4:24 PM Mark Brown wrote: > > On Fri, Mar 12, 2021 at 02:37:30PM +0200, Daniel Baluta wrote: > > On Fri, Mar 12, 2021 at 1:59 PM Mark Brown wrote: > > > > No, just the opposite! If there's an explict name configured why do you > > > want to ignore it? > > > Because the in

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-12 Thread Mark Brown
On Fri, Mar 12, 2021 at 02:37:30PM +0200, Daniel Baluta wrote: > On Fri, Mar 12, 2021 at 1:59 PM Mark Brown wrote: > > No, just the opposite! If there's an explict name configured why do you > > want to ignore it? > Because the initial assignment: > dai_link->platforms->name = component->name;

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-12 Thread Daniel Baluta
On Fri, Mar 12, 2021 at 1:59 PM Mark Brown wrote: > > On Fri, Mar 12, 2021 at 12:59:29PM +0200, Daniel Baluta wrote: > > On Fri, Mar 12, 2021 at 12:50 PM Mark Brown wrote: > > > > If an explicit name has been provided why would we override it with an > > > autogenerated one? > > > Wait, are you a

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-12 Thread Mark Brown
On Fri, Mar 12, 2021 at 12:59:29PM +0200, Daniel Baluta wrote: > On Fri, Mar 12, 2021 at 12:50 PM Mark Brown wrote: > > If an explicit name has been provided why would we override it with an > > autogenerated one? > Wait, are you asking why the initial code: > dai_link->platforms->name = comp

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-12 Thread Daniel Baluta
On Fri, Mar 12, 2021 at 12:50 PM Mark Brown wrote: > > On Fri, Mar 12, 2021 at 10:32:54AM +0200, Daniel Baluta wrote: > > On Tue, Mar 9, 2021 at 5:38 PM Mark Brown wrote: > > > > > + if (!dai_link->platforms->of_node) > > > > + dai_link->platforms->

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-12 Thread Mark Brown
On Fri, Mar 12, 2021 at 10:32:54AM +0200, Daniel Baluta wrote: > On Tue, Mar 9, 2021 at 5:38 PM Mark Brown wrote: > > > + if (!dai_link->platforms->of_node) > > > + dai_link->platforms->name = component->name; > > Why would we prefer the node name

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-12 Thread Daniel Baluta
On Tue, Mar 9, 2021 at 5:38 PM Mark Brown wrote: > > On Tue, Mar 09, 2021 at 10:23:28AM +0200, Daniel Baluta wrote: > > From: Daniel Baluta > > > > Platform may be specified by either name or OF node but not > > both. > > > > For OF node platforms (e.g i.MX) we end up with both platform name > >

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-09 Thread Mark Brown
On Tue, Mar 09, 2021 at 10:23:28AM +0200, Daniel Baluta wrote: > From: Daniel Baluta > > Platform may be specified by either name or OF node but not > both. > > For OF node platforms (e.g i.MX) we end up with both platform name > and of_node set and sound card registration will fail with the err

[PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-09 Thread Daniel Baluta
From: Daniel Baluta Platform may be specified by either name or OF node but not both. For OF node platforms (e.g i.MX) we end up with both platform name and of_node set and sound card registration will fail with the error: asoc-simple-card sof-sound-wm8960: ASoC: Neither/both platform name/