Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-07 Thread Mark Brown
On Tue, Nov 06, 2018 at 04:41:23PM +0100, Arnaud Pouliquen wrote: > I would say force device to 0 if no_pcm (need probably to create the > control in hdmi_of_xlate_dai_id instead of hdmi_codec_pcm_new). > But keep in mind that solution has to work in case of multi HDMI codec > instances, perhaps

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-07 Thread Mark Brown
On Tue, Nov 06, 2018 at 04:41:23PM +0100, Arnaud Pouliquen wrote: > I would say force device to 0 if no_pcm (need probably to create the > control in hdmi_of_xlate_dai_id instead of hdmi_codec_pcm_new). > But keep in mind that solution has to work in case of multi HDMI codec > instances, perhaps

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-06 Thread Arnaud Pouliquen
Hello Rohit On 11/5/18 7:14 PM, Rohit Kumar wrote: > Hello Arnaud, > > > On 11/5/2018 4:43 PM, Arnaud Pouliquen wrote: >> Hello Rohit, >> >> On 11/2/18 1:06 PM, Rohit Kumar wrote: >>> On 11/2/2018 1:12 PM, Takashi Iwai wrote: On Thu, 01 Nov 2018 13:38:49 +0100, Rohit kumar wrote:

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-06 Thread Arnaud Pouliquen
Hello Rohit On 11/5/18 7:14 PM, Rohit Kumar wrote: > Hello Arnaud, > > > On 11/5/2018 4:43 PM, Arnaud Pouliquen wrote: >> Hello Rohit, >> >> On 11/2/18 1:06 PM, Rohit Kumar wrote: >>> On 11/2/2018 1:12 PM, Takashi Iwai wrote: On Thu, 01 Nov 2018 13:38:49 +0100, Rohit kumar wrote:

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-05 Thread Rohit Kumar
Hello Arnaud, On 11/5/2018 4:43 PM, Arnaud Pouliquen wrote: Hello Rohit, On 11/2/18 1:06 PM, Rohit Kumar wrote: On 11/2/2018 1:12 PM, Takashi Iwai wrote: On Thu, 01 Nov 2018 13:38:49 +0100, Rohit kumar wrote: Remove no_pcm check to invoke pcm_new() for backend dai-links too. This fixes

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-05 Thread Rohit Kumar
Hello Arnaud, On 11/5/2018 4:43 PM, Arnaud Pouliquen wrote: Hello Rohit, On 11/2/18 1:06 PM, Rohit Kumar wrote: On 11/2/2018 1:12 PM, Takashi Iwai wrote: On Thu, 01 Nov 2018 13:38:49 +0100, Rohit kumar wrote: Remove no_pcm check to invoke pcm_new() for backend dai-links too. This fixes

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-05 Thread Arnaud Pouliquen
Hello Rohit, On 11/2/18 1:06 PM, Rohit Kumar wrote: > > On 11/2/2018 1:12 PM, Takashi Iwai wrote: >> On Thu, 01 Nov 2018 13:38:49 +0100, >> Rohit kumar wrote: >>> Remove no_pcm check to invoke pcm_new() for backend dai-links >>> too. This fixes crash in hdmi codec driver during

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-05 Thread Arnaud Pouliquen
Hello Rohit, On 11/2/18 1:06 PM, Rohit Kumar wrote: > > On 11/2/2018 1:12 PM, Takashi Iwai wrote: >> On Thu, 01 Nov 2018 13:38:49 +0100, >> Rohit kumar wrote: >>> Remove no_pcm check to invoke pcm_new() for backend dai-links >>> too. This fixes crash in hdmi codec driver during

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-02 Thread Rohit Kumar
On 11/2/2018 1:12 PM, Takashi Iwai wrote: On Thu, 01 Nov 2018 13:38:49 +0100, Rohit kumar wrote: Remove no_pcm check to invoke pcm_new() for backend dai-links too. This fixes crash in hdmi codec driver during hdmi_codec_startup() while accessing chmap_info struct. chmap_info struct memory is

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-02 Thread Rohit Kumar
On 11/2/2018 1:12 PM, Takashi Iwai wrote: On Thu, 01 Nov 2018 13:38:49 +0100, Rohit kumar wrote: Remove no_pcm check to invoke pcm_new() for backend dai-links too. This fixes crash in hdmi codec driver during hdmi_codec_startup() while accessing chmap_info struct. chmap_info struct memory is

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-02 Thread Takashi Iwai
On Thu, 01 Nov 2018 13:38:49 +0100, Rohit kumar wrote: > > Remove no_pcm check to invoke pcm_new() for backend dai-links > too. This fixes crash in hdmi codec driver during hdmi_codec_startup() > while accessing chmap_info struct. chmap_info struct memory is > allocated in pcm_new() of hdmi codec

Re: [alsa-devel] [PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-02 Thread Takashi Iwai
On Thu, 01 Nov 2018 13:38:49 +0100, Rohit kumar wrote: > > Remove no_pcm check to invoke pcm_new() for backend dai-links > too. This fixes crash in hdmi codec driver during hdmi_codec_startup() > while accessing chmap_info struct. chmap_info struct memory is > allocated in pcm_new() of hdmi codec

[PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-01 Thread Rohit kumar
Remove no_pcm check to invoke pcm_new() for backend dai-links too. This fixes crash in hdmi codec driver during hdmi_codec_startup() while accessing chmap_info struct. chmap_info struct memory is allocated in pcm_new() of hdmi codec driver which is not invoked in case of DPCM when hdmi codec

[PATCH] ASoC: core: Invoke pcm_new() for all DAI-link

2018-11-01 Thread Rohit kumar
Remove no_pcm check to invoke pcm_new() for backend dai-links too. This fixes crash in hdmi codec driver during hdmi_codec_startup() while accessing chmap_info struct. chmap_info struct memory is allocated in pcm_new() of hdmi codec driver which is not invoked in case of DPCM when hdmi codec