RE: [PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases

2012-12-20 Thread Liu, Chuansheng
ect: Re: [PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases > > On Thu, Dec 20, 2012 at 06:37:26AM +, Liu, Chuansheng wrote: > > > Meanwhile, is it useful to add one warning there for that case? > > After all, in probing, set the bias to _STANDBY even idle_bia

Re: [PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases

2012-12-20 Thread Mark Brown
On Thu, Dec 20, 2012 at 06:37:26AM +, Liu, Chuansheng wrote: > Meanwhile, is it useful to add one warning there for that case? > After all, in probing, set the bias to _STANDBY even idle_bias_off == 1, and > calling get_runtime_sync(), it > will let the code more obscure. So giving a warning

RE: [PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases

2012-12-19 Thread Liu, Chuansheng
; Subject: Re: [PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases > > On Wed, Dec 19, 2012 at 06:36:37PM +0800, Chuansheng Liu wrote: > > > But some devices has been set to STANDY bias directly during device probing, > > such as cs42l73_probe(): > > cs42l73_set_bias

Re: [PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases

2012-12-19 Thread Mark Brown
On Wed, Dec 19, 2012 at 06:36:37PM +0800, Chuansheng Liu wrote: > But some devices has been set to STANDY bias directly during device probing, > such as cs42l73_probe(): > cs42l73_set_bias_level(codec, SND_SOC_BIAS_STANDBY); > Then it will cause runtime_get() not be called but laterly runtime_put

[PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases

2012-12-18 Thread Chuansheng Liu
Commit f1aac484f7(Take a pm_runtime reference on DAPM devices that are enabled) introduced runtime_get/put calling when devices are in off/non-off bias. It is based on: 1/ device from off to non-off bias is called thru dapm_pre_sequence_async; 2/ device from non-off to off bias is called thru dap