Re: [PATCH] ASoC: es8316: limit headphone mixer volume

2019-08-26 Thread Katsuhiro Suzuki
Hello Hans, Daniel, Thank you for reviewing and comment. On 2019/08/26 18:09, Hans de Goede wrote: Hi, On 26-08-19 04:53, Daniel Drake wrote: On Mon, Aug 26, 2019 at 1:38 AM Hans de Goede wrote: On 24-08-19 23:04, Katsuhiro Suzuki wrote: This patch limits Headphone mixer volume to 4 from 7

Re: [PATCH] ASoC: es8316: limit headphone mixer volume

2019-08-26 Thread Hans de Goede
Hi, On 26-08-19 04:53, Daniel Drake wrote: On Mon, Aug 26, 2019 at 1:38 AM Hans de Goede wrote: On 24-08-19 23:04, Katsuhiro Suzuki wrote: This patch limits Headphone mixer volume to 4 from 7. Because output sound suddenly becomes very loudly with many noise if set volume over 4. That sound

Re: [PATCH] ASoC: es8316: limit headphone mixer volume

2019-08-26 Thread Katsuhiro Suzuki
Hello, Oops... I got mistake, > SOC_DOUBLE_TLV("Headphone Mixer Volume", ES8316_HPMIX_VOL, > 0, 4, 15, 0, hpmixer_gain_tlv), is wrong, > SOC_DOUBLE_TLV("Headphone Mixer Volume", ES8316_HPMIX_VOL, > 0, 4, 11, 0, hpmixer_gain_tlv), is correct. Best Reg

Re: [PATCH] ASoC: es8316: limit headphone mixer volume

2019-08-26 Thread Katsuhiro Suzuki
Hello Daniel, On 2019/08/26 11:53, Daniel Drake wrote: On Mon, Aug 26, 2019 at 1:38 AM Hans de Goede wrote: On 24-08-19 23:04, Katsuhiro Suzuki wrote: This patch limits Headphone mixer volume to 4 from 7. Because output sound suddenly becomes very loudly with many noise if set volume over 4.

Re: [PATCH] ASoC: es8316: limit headphone mixer volume

2019-08-25 Thread Daniel Drake
On Mon, Aug 26, 2019 at 1:38 AM Hans de Goede wrote: > On 24-08-19 23:04, Katsuhiro Suzuki wrote: > > This patch limits Headphone mixer volume to 4 from 7. > > Because output sound suddenly becomes very loudly with many noise if > > set volume over 4. That sounds like something that should be lim

Re: [PATCH] ASoC: es8316: limit headphone mixer volume

2019-08-25 Thread Hans de Goede
Hi, On 24-08-19 23:04, Katsuhiro Suzuki wrote: This patch limits Headphone mixer volume to 4 from 7. Because output sound suddenly becomes very loudly with many noise if set volume over 4. Signed-off-by: Katsuhiro Suzuki Higher then 4 not working matches my experience, see this comment from

[PATCH] ASoC: es8316: limit headphone mixer volume

2019-08-24 Thread Katsuhiro Suzuki
This patch limits Headphone mixer volume to 4 from 7. Because output sound suddenly becomes very loudly with many noise if set volume over 4. Signed-off-by: Katsuhiro Suzuki --- sound/soc/codecs/es8316.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/es8316.