Re: [PATCH] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

2014-01-27 Thread Mark Brown
On Thu, Jan 23, 2014 at 03:48:03PM +0800, Xiubo Li wrote: > Signed-off-by: Xiubo Li > Cc: Nicolin Chen > --- > sound/soc/fsl/fsl_sai.c | 243 > +--- > sound/soc/fsl/fsl_sai.h | 47 +- This is fine but it doesn't seem to apply against

Re: [PATCH] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

2014-01-27 Thread Mark Brown
On Thu, Jan 23, 2014 at 03:48:03PM +0800, Xiubo Li wrote: Signed-off-by: Xiubo Li li.xi...@freescale.com Cc: Nicolin Chen guangyu.c...@freescale.com --- sound/soc/fsl/fsl_sai.c | 243 +--- sound/soc/fsl/fsl_sai.h | 47 +- This is fine

Re: [alsa-devel] [PATCH] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

2014-01-23 Thread Fabio Estevam
On Thu, Jan 23, 2014 at 8:32 AM, li.xi...@freescale.com wrote: > The clock operations in the driver is only related to the module clock, and > has > move to the regmap core and regmap core will to the same clock operations at > proper time, since we are using: > > + sai->regmap =

RE: [alsa-devel] [PATCH] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

2014-01-23 Thread li.xi...@freescale.com
> > static int fsl_sai_set_dai_sysclk(struct snd_soc_dai *cpu_dai, > > int clk_id, unsigned int freq, int dir) > > { > > - struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai); > > int ret; > > > > if (dir == SND_SOC_CLOCK_IN) > > return

Re: [alsa-devel] [PATCH] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

2014-01-23 Thread Fabio Estevam
On Thu, Jan 23, 2014 at 5:48 AM, Xiubo Li wrote: > static int fsl_sai_set_dai_sysclk(struct snd_soc_dai *cpu_dai, > int clk_id, unsigned int freq, int dir) > { > - struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai); > int ret; > > if (dir ==

[PATCH] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

2014-01-23 Thread Xiubo Li
Signed-off-by: Xiubo Li Cc: Nicolin Chen --- sound/soc/fsl/fsl_sai.c | 243 +--- sound/soc/fsl/fsl_sai.h | 47 +- 2 files changed, 150 insertions(+), 140 deletions(-) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index

[PATCH] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

2014-01-23 Thread Xiubo Li
Signed-off-by: Xiubo Li li.xi...@freescale.com Cc: Nicolin Chen guangyu.c...@freescale.com --- sound/soc/fsl/fsl_sai.c | 243 +--- sound/soc/fsl/fsl_sai.h | 47 +- 2 files changed, 150 insertions(+), 140 deletions(-) diff --git

Re: [alsa-devel] [PATCH] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

2014-01-23 Thread Fabio Estevam
On Thu, Jan 23, 2014 at 5:48 AM, Xiubo Li li.xi...@freescale.com wrote: static int fsl_sai_set_dai_sysclk(struct snd_soc_dai *cpu_dai, int clk_id, unsigned int freq, int dir) { - struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai); int ret; if

RE: [alsa-devel] [PATCH] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

2014-01-23 Thread li.xi...@freescale.com
static int fsl_sai_set_dai_sysclk(struct snd_soc_dai *cpu_dai, int clk_id, unsigned int freq, int dir) { - struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai); int ret; if (dir == SND_SOC_CLOCK_IN) return 0; -

Re: [alsa-devel] [PATCH] ASoC: fsl-sai: convert to use regmap API for Freeacale SAI

2014-01-23 Thread Fabio Estevam
On Thu, Jan 23, 2014 at 8:32 AM, li.xi...@freescale.com li.xi...@freescale.com wrote: The clock operations in the driver is only related to the module clock, and has move to the regmap core and regmap core will to the same clock operations at proper time, since we are using: +