Re: [PATCH] ASoC: fsl_asrc: protect macro argument

2017-12-06 Thread Stefan Agner
On 2017-12-06 15:39, Mark Brown wrote: > On Wed, Dec 06, 2017 at 03:25:37PM +0100, Stefan Agner wrote: >> On 2017-12-06 15:11, Mark Brown wrote: > [...] >> I did not meant to bug people, just wanted to make sure the patch does >> not falls through the cracks... After all, patch as well as the Ack

Re: [PATCH] ASoC: fsl_asrc: protect macro argument

2017-12-06 Thread Stefan Agner
On 2017-12-06 15:39, Mark Brown wrote: > On Wed, Dec 06, 2017 at 03:25:37PM +0100, Stefan Agner wrote: >> On 2017-12-06 15:11, Mark Brown wrote: > [...] >> I did not meant to bug people, just wanted to make sure the patch does >> not falls through the cracks... After all, patch as well as the Ack

Re: [PATCH] ASoC: fsl_asrc: protect macro argument

2017-12-06 Thread Mark Brown
On Wed, Dec 06, 2017 at 03:25:37PM +0100, Stefan Agner wrote: > On 2017-12-06 15:11, Mark Brown wrote: > > Please don't send content free pings and please allow a reasonable time > > for review. People get busy, go on holiday, attend conferences and so > > on so unless there is some reason for

Re: [PATCH] ASoC: fsl_asrc: protect macro argument

2017-12-06 Thread Mark Brown
On Wed, Dec 06, 2017 at 03:25:37PM +0100, Stefan Agner wrote: > On 2017-12-06 15:11, Mark Brown wrote: > > Please don't send content free pings and please allow a reasonable time > > for review. People get busy, go on holiday, attend conferences and so > > on so unless there is some reason for

Re: [PATCH] ASoC: fsl_asrc: protect macro argument

2017-12-06 Thread Stefan Agner
On 2017-12-06 15:11, Mark Brown wrote: > On Wed, Dec 06, 2017 at 02:53:39PM +0100, Stefan Agner wrote: >> On 2017-08-07 09:08, Nicolin Chen wrote: >> > On Sun, Aug 06, 2017 at 11:36:57PM -0700, Stefan Agner wrote: > >> Mark, you seem to have merged other patches for this driver, can you >> merge

Re: [PATCH] ASoC: fsl_asrc: protect macro argument

2017-12-06 Thread Stefan Agner
On 2017-12-06 15:11, Mark Brown wrote: > On Wed, Dec 06, 2017 at 02:53:39PM +0100, Stefan Agner wrote: >> On 2017-08-07 09:08, Nicolin Chen wrote: >> > On Sun, Aug 06, 2017 at 11:36:57PM -0700, Stefan Agner wrote: > >> Mark, you seem to have merged other patches for this driver, can you >> merge

Re: [PATCH] ASoC: fsl_asrc: protect macro argument

2017-12-06 Thread Mark Brown
On Wed, Dec 06, 2017 at 02:53:39PM +0100, Stefan Agner wrote: > On 2017-08-07 09:08, Nicolin Chen wrote: > > On Sun, Aug 06, 2017 at 11:36:57PM -0700, Stefan Agner wrote: > Mark, you seem to have merged other patches for this driver, can you > merge this one too? Please don't send content free

Re: [PATCH] ASoC: fsl_asrc: protect macro argument

2017-12-06 Thread Mark Brown
On Wed, Dec 06, 2017 at 02:53:39PM +0100, Stefan Agner wrote: > On 2017-08-07 09:08, Nicolin Chen wrote: > > On Sun, Aug 06, 2017 at 11:36:57PM -0700, Stefan Agner wrote: > Mark, you seem to have merged other patches for this driver, can you > merge this one too? Please don't send content free

Re: [PATCH] ASoC: fsl_asrc: protect macro argument

2017-12-06 Thread Stefan Agner
On 2017-08-07 09:08, Nicolin Chen wrote: > On Sun, Aug 06, 2017 at 11:36:57PM -0700, Stefan Agner wrote: >> Protect macro argument with parentheses to avoid ambiguity. >> This fixes a warning seen with clang: >> warning: logical not is only applied to the left hand side of this >> comparison >>

Re: [PATCH] ASoC: fsl_asrc: protect macro argument

2017-12-06 Thread Stefan Agner
On 2017-08-07 09:08, Nicolin Chen wrote: > On Sun, Aug 06, 2017 at 11:36:57PM -0700, Stefan Agner wrote: >> Protect macro argument with parentheses to avoid ambiguity. >> This fixes a warning seen with clang: >> warning: logical not is only applied to the left hand side of this >> comparison >>

Re: [PATCH] ASoC: fsl_asrc: protect macro argument

2017-08-07 Thread Nicolin Chen
On Sun, Aug 06, 2017 at 11:36:57PM -0700, Stefan Agner wrote: > Protect macro argument with parentheses to avoid ambiguity. > This fixes a warning seen with clang: > warning: logical not is only applied to the left hand side of this > comparison > > Signed-off-by: Stefan Agner

Re: [PATCH] ASoC: fsl_asrc: protect macro argument

2017-08-07 Thread Nicolin Chen
On Sun, Aug 06, 2017 at 11:36:57PM -0700, Stefan Agner wrote: > Protect macro argument with parentheses to avoid ambiguity. > This fixes a warning seen with clang: > warning: logical not is only applied to the left hand side of this > comparison > > Signed-off-by: Stefan Agner Acked-by:

[PATCH] ASoC: fsl_asrc: protect macro argument

2017-08-07 Thread Stefan Agner
Protect macro argument with parentheses to avoid ambiguity. This fixes a warning seen with clang: warning: logical not is only applied to the left hand side of this comparison Signed-off-by: Stefan Agner --- sound/soc/fsl/fsl_asrc.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] ASoC: fsl_asrc: protect macro argument

2017-08-07 Thread Stefan Agner
Protect macro argument with parentheses to avoid ambiguity. This fixes a warning seen with clang: warning: logical not is only applied to the left hand side of this comparison Signed-off-by: Stefan Agner --- sound/soc/fsl/fsl_asrc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff