RE: [PATCH] ASoC: intel: sof_rt5682: Add support for tgl_rt1011_rt5682

2020-12-03 Thread Lu, Brent
> > +struct { > > + unsigned int tx; > > + unsigned int rx; > > +} rt1011_tdm_mask[] = { > > + {.tx = 0x4, .rx = 0x1}, > > + {.tx = 0x8, .rx = 0x2}, > > +}; > > as noted in the GitHub review this should be static and possibly const. Will fix in v2. Also add const to structures in

Re: [PATCH] ASoC: intel: sof_rt5682: Add support for tgl_rt1011_rt5682

2020-12-02 Thread Pierre-Louis Bossart
+struct { + unsigned int tx; + unsigned int rx; +} rt1011_tdm_mask[] = { + {.tx = 0x4, .rx = 0x1}, + {.tx = 0x8, .rx = 0x2}, +}; as noted in the GitHub review this should be static and possibly const.

[PATCH] ASoC: intel: sof_rt5682: Add support for tgl_rt1011_rt5682

2020-12-01 Thread Brent Lu
This patch adds the driver data for two rt1011 speaker amplifiers on SSP1 and rt5682 on SSP0 for TGL platform. DAI format for rt1011 is leveraged from cml_rt1011_rt5682 which is 4-slot tdm with 100fs bclk. Signed-off-by: Brent Lu --- sound/soc/intel/boards/Kconfig| 1 +