On Mon, Jul 15, 2013 at 11:58:36PM +0100, Mark Brown wrote:
> On Mon, Jul 15, 2013 at 10:37:27PM +0100, Russell King - ARM Linux wrote:
> > I suggest you go back and re-read the driver because it most certainly
> > does use extclk. What makes you think it won't?
> The only thing I can see which
On Mon, Jul 15, 2013 at 11:58:36PM +0100, Mark Brown wrote:
> The only thing I can see which is pushing a constraint up the stack is
> KIRKWOOD_I2S_RATES in the DAIs which only allows 44.1kHz, 48kHz and
> 96kHz, the rates for which the internal clock is used.
Take a closer look, because you are mi
On Mon, Jul 15, 2013 at 10:37:27PM +0100, Russell King - ARM Linux wrote:
> On Mon, Jul 15, 2013 at 09:08:51PM +0100, Mark Brown wrote:
> > There's no obvious code that handles anything differently with extclk.
> > Indeed if you think about it for a minute you'll realise there's no way
> > the dri
On Mon, Jul 15, 2013 at 09:08:51PM +0100, Mark Brown wrote:
> There's no obvious code that handles anything differently with extclk.
> Indeed if you think about it for a minute you'll realise there's no way
> the driver will ever use an extclk - set_rate() is badly implemented,
> look at how other
On Mon, Jul 15, 2013 at 08:37:56PM +0200, Jean-Francois Moine wrote:
> Mark Brown wrote:
> > I'd really like to see an analysis explaining why this can never happen,
> > the driver explicitly supports running without extclk being provided.
> > Simply asserting that we should never get such a rate
On Mon, 15 Jul 2013 16:31:01 +0100
Mark Brown wrote:
> On Mon, Jul 15, 2013 at 10:36:44AM +0200, Jean-Francois Moine wrote:
> > In the function kirkwood_set_rate, when the rate cannot be satisfied
> > by the internal nor by an external clock, the clock source in undefined:
>
> > warning: ‘clks_
On Mon, Jul 15, 2013 at 10:36:44AM +0200, Jean-Francois Moine wrote:
> In the function kirkwood_set_rate, when the rate cannot be satisfied
> by the internal nor by an external clock, the clock source in undefined:
> warning: ‘clks_ctrl’ may be used uninitialized in this function
> As the ALSA s
In the function kirkwood_set_rate, when the rate cannot be satisfied
by the internal nor by an external clock, the clock source in undefined:
warning: ‘clks_ctrl’ may be used uninitialized in this function
As the ALSA subsystem should never gives such a rate, this patch removes
the check of the
8 matches
Mail list logo
