Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-07 Thread Grant Grundler
On Fri, Sep 7, 2018 at 10:56 AM Mark Brown wrote: > > On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote: > > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: > > > > Note that this isn't causing a warning upstream, presumably due to an > > > implicit inclusion that isn't present in

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-07 Thread Grant Grundler
On Fri, Sep 7, 2018 at 10:56 AM Mark Brown wrote: > > On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote: > > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: > > > > Note that this isn't causing a warning upstream, presumably due to an > > > implicit inclusion that isn't present in

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-07 Thread Mark Brown
On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote: > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: > > Note that this isn't causing a warning upstream, presumably due to an > > implicit inclusion that isn't present in the v4.4 kernel that you appear > > to be using, or gets

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-07 Thread Mark Brown
On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote: > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: > > Note that this isn't causing a warning upstream, presumably due to an > > implicit inclusion that isn't present in the v4.4 kernel that you appear > > to be using, or gets

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-07 Thread Grant Grundler
[resending as plain/text - sorry] On Fri, Sep 7, 2018 at 10:52 AM Grant Grundler wrote: > > > > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: >> >> On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote: >> > Commit ca917f9fe1a0fab added use of usleep_range() but not >> > the

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-07 Thread Grant Grundler
[resending as plain/text - sorry] On Fri, Sep 7, 2018 at 10:52 AM Grant Grundler wrote: > > > > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: >> >> On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote: >> > Commit ca917f9fe1a0fab added use of usleep_range() but not >> > the

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-07 Thread Mark Brown
On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote: > Commit ca917f9fe1a0fab added use of usleep_range() but not > the corresponding "include ". The result is > with Chrome OS won't build because warnings are forced > to be errors: >

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-07 Thread Mark Brown
On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote: > Commit ca917f9fe1a0fab added use of usleep_range() but not > the corresponding "include ". The result is > with Chrome OS won't build because warnings are forced > to be errors: >

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-06 Thread Benson Leung
Hi Grant, On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote: > Commit ca917f9fe1a0fab added use of usleep_range() but not > the corresponding "include ". The result is > with Chrome OS won't build because warnings are forced > to be errors: >

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-06 Thread Benson Leung
Hi Grant, On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote: > Commit ca917f9fe1a0fab added use of usleep_range() but not > the corresponding "include ". The result is > with Chrome OS won't build because warnings are forced > to be errors: >

[PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-06 Thread Grant Grundler
Commit ca917f9fe1a0fab added use of usleep_range() but not the corresponding "include ". The result is with Chrome OS won't build because warnings are forced to be errors: mnt/host/source/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2: error: implicit declaration of function

[PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-06 Thread Grant Grundler
Commit ca917f9fe1a0fab added use of usleep_range() but not the corresponding "include ". The result is with Chrome OS won't build because warnings are forced to be errors: mnt/host/source/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2: error: implicit declaration of function