Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-26 Thread Mark Brown
On Fri, Feb 26, 2016 at 09:43:15AM -0600, Pierre-Louis Bossart wrote: > Yes there are documentation and helpers I looked into, but to the best of my > limited knowledge not for the gate + dual-rate case. Then you jump to > complicated configurations combining multiple base clocks that don't

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-26 Thread Mark Brown
On Fri, Feb 26, 2016 at 09:43:15AM -0600, Pierre-Louis Bossart wrote: > Yes there are documentation and helpers I looked into, but to the best of my > limited knowledge not for the gate + dual-rate case. Then you jump to > complicated configurations combining multiple base clocks that don't

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-26 Thread Pierre-Louis Bossart
On 2/25/16 7:08 PM, Mark Brown wrote: On Wed, Feb 24, 2016 at 10:10:05AM -0600, Pierre-Louis Bossart wrote: On 2/23/16 9:32 PM, Mark Brown wrote: That said we really do need x86 to transition to use the clock API in order to integrate with external devices, where the machine driver does

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-26 Thread Pierre-Louis Bossart
On 2/25/16 7:08 PM, Mark Brown wrote: On Wed, Feb 24, 2016 at 10:10:05AM -0600, Pierre-Louis Bossart wrote: On 2/23/16 9:32 PM, Mark Brown wrote: That said we really do need x86 to transition to use the clock API in order to integrate with external devices, where the machine driver does

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-25 Thread Mark Brown
On Wed, Feb 24, 2016 at 10:10:05AM -0600, Pierre-Louis Bossart wrote: > On 2/23/16 9:32 PM, Mark Brown wrote: > >That said we really do need x86 to transition to use the clock API > >in order to integrate with external devices, where the machine driver > >does manage clocks we want that to move

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-25 Thread Mark Brown
On Wed, Feb 24, 2016 at 10:10:05AM -0600, Pierre-Louis Bossart wrote: > On 2/23/16 9:32 PM, Mark Brown wrote: > >That said we really do need x86 to transition to use the clock API > >in order to integrate with external devices, where the machine driver > >does manage clocks we want that to move

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-24 Thread Pierre-Louis Bossart
On 2/23/16 9:32 PM, Mark Brown wrote: On Wed, Feb 24, 2016 at 12:08:31AM +0100, Heiko Stuebner wrote: Am Dienstag, 23. Februar 2016, 08:50:04 schrieb Pierre-Louis Bossart: This patch assumes that the information on mclk comes from DeviceTree. The mclk may also be enabled/disabled in the

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-24 Thread Pierre-Louis Bossart
On 2/23/16 9:32 PM, Mark Brown wrote: On Wed, Feb 24, 2016 at 12:08:31AM +0100, Heiko Stuebner wrote: Am Dienstag, 23. Februar 2016, 08:50:04 schrieb Pierre-Louis Bossart: This patch assumes that the information on mclk comes from DeviceTree. The mclk may also be enabled/disabled in the

Re: [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-23 Thread Mark Brown
On Tue, Feb 23, 2016 at 09:26:22AM +0800, Sugar Zhang wrote: > enable/disable master clock when codec is active or not. This patch has already been applied, please send incremental patches if any changes are required. signature.asc Description: PGP signature

Re: [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-23 Thread Mark Brown
On Tue, Feb 23, 2016 at 09:26:22AM +0800, Sugar Zhang wrote: > enable/disable master clock when codec is active or not. This patch has already been applied, please send incremental patches if any changes are required. signature.asc Description: PGP signature

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-23 Thread Mark Brown
On Wed, Feb 24, 2016 at 12:08:31AM +0100, Heiko Stuebner wrote: > Am Dienstag, 23. Februar 2016, 08:50:04 schrieb Pierre-Louis Bossart: > > This patch assumes that the information on mclk comes from DeviceTree. > > The mclk may also be enabled/disabled in the machine driver with an > > explicit

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-23 Thread Mark Brown
On Wed, Feb 24, 2016 at 12:08:31AM +0100, Heiko Stuebner wrote: > Am Dienstag, 23. Februar 2016, 08:50:04 schrieb Pierre-Louis Bossart: > > This patch assumes that the information on mclk comes from DeviceTree. > > The mclk may also be enabled/disabled in the machine driver with an > > explicit

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-23 Thread Heiko Stuebner
Am Dienstag, 23. Februar 2016, 08:50:04 schrieb Pierre-Louis Bossart: > On 2/22/16 7:26 PM, Sugar Zhang wrote: > > enable/disable master clock when codec is active or not. > > > > Signed-off-by: Sugar Zhang > > --- > > > >

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-23 Thread Heiko Stuebner
Am Dienstag, 23. Februar 2016, 08:50:04 schrieb Pierre-Louis Bossart: > On 2/22/16 7:26 PM, Sugar Zhang wrote: > > enable/disable master clock when codec is active or not. > > > > Signed-off-by: Sugar Zhang > > --- > > > > Documentation/devicetree/bindings/sound/rt5640.txt | 3 +++ > >

Re: [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-23 Thread Rob Herring
On Tue, Feb 23, 2016 at 09:26:22AM +0800, Sugar Zhang wrote: > enable/disable master clock when codec is active or not. > > Signed-off-by: Sugar Zhang > --- > > Documentation/devicetree/bindings/sound/rt5640.txt | 3 +++ Acked-by: Rob Herring >

Re: [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-23 Thread Rob Herring
On Tue, Feb 23, 2016 at 09:26:22AM +0800, Sugar Zhang wrote: > enable/disable master clock when codec is active or not. > > Signed-off-by: Sugar Zhang > --- > > Documentation/devicetree/bindings/sound/rt5640.txt | 3 +++ Acked-by: Rob Herring > sound/soc/codecs/rt5640.c

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-23 Thread Pierre-Louis Bossart
On 2/22/16 7:26 PM, Sugar Zhang wrote: enable/disable master clock when codec is active or not. Signed-off-by: Sugar Zhang --- Documentation/devicetree/bindings/sound/rt5640.txt | 3 +++ sound/soc/codecs/rt5640.c | 31

Re: [alsa-devel] [PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-23 Thread Pierre-Louis Bossart
On 2/22/16 7:26 PM, Sugar Zhang wrote: enable/disable master clock when codec is active or not. Signed-off-by: Sugar Zhang --- Documentation/devicetree/bindings/sound/rt5640.txt | 3 +++ sound/soc/codecs/rt5640.c | 31 ++

[PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-22 Thread Sugar Zhang
enable/disable master clock when codec is active or not. Signed-off-by: Sugar Zhang --- Documentation/devicetree/bindings/sound/rt5640.txt | 3 +++ sound/soc/codecs/rt5640.c | 31 ++ sound/soc/codecs/rt5640.h

[PATCH] ASoC: rt5640: add master clock handling for rt5640

2016-02-22 Thread Sugar Zhang
enable/disable master clock when codec is active or not. Signed-off-by: Sugar Zhang --- Documentation/devicetree/bindings/sound/rt5640.txt | 3 +++ sound/soc/codecs/rt5640.c | 31 ++ sound/soc/codecs/rt5640.h | 2 ++ 3