Re: [PATCH] ASoC: samsung: s3c2412: cleanups / fixes for preparation of clocks.

2017-07-26 Thread Arvind Yadav
Hi, On Thursday 27 July 2017 12:42 AM, Krzysztof Kozlowski wrote: On Thu, Jul 27, 2017 at 12:28:52AM +0530, Arvind Yadav wrote: -Use devm_clk_get() to make cleanup paths more simple. -clk_prepare_enable() can fail here and we must check its return value. -Add s3c_i2sv2_remove cleanup function

Re: [PATCH] ASoC: samsung: s3c2412: cleanups / fixes for preparation of clocks.

2017-07-26 Thread Arvind Yadav
Hi, On Thursday 27 July 2017 12:42 AM, Krzysztof Kozlowski wrote: On Thu, Jul 27, 2017 at 12:28:52AM +0530, Arvind Yadav wrote: -Use devm_clk_get() to make cleanup paths more simple. -clk_prepare_enable() can fail here and we must check its return value. -Add s3c_i2sv2_remove cleanup function

Re: [PATCH] ASoC: samsung: s3c2412: cleanups / fixes for preparation of clocks.

2017-07-26 Thread Krzysztof Kozlowski
On Thu, Jul 27, 2017 at 12:28:52AM +0530, Arvind Yadav wrote: > -Use devm_clk_get() to make cleanup paths more simple. > -clk_prepare_enable() can fail here and we must check its return value. > -Add s3c_i2sv2_remove cleanup function of s3c_i2sv2_probe. > -No need to iounmap. Here, mapping done by

Re: [PATCH] ASoC: samsung: s3c2412: cleanups / fixes for preparation of clocks.

2017-07-26 Thread Krzysztof Kozlowski
On Thu, Jul 27, 2017 at 12:28:52AM +0530, Arvind Yadav wrote: > -Use devm_clk_get() to make cleanup paths more simple. > -clk_prepare_enable() can fail here and we must check its return value. > -Add s3c_i2sv2_remove cleanup function of s3c_i2sv2_probe. > -No need to iounmap. Here, mapping done by

[PATCH] ASoC: samsung: s3c2412: cleanups / fixes for preparation of clocks.

2017-07-26 Thread Arvind Yadav
-Use devm_clk_get() to make cleanup paths more simple. -clk_prepare_enable() can fail here and we must check its return value. -Add s3c_i2sv2_remove cleanup function of s3c_i2sv2_probe. -No need to iounmap. Here, mapping done by devm_ioremap_resource. Signed-off-by: Arvind Yadav

[PATCH] ASoC: samsung: s3c2412: cleanups / fixes for preparation of clocks.

2017-07-26 Thread Arvind Yadav
-Use devm_clk_get() to make cleanup paths more simple. -clk_prepare_enable() can fail here and we must check its return value. -Add s3c_i2sv2_remove cleanup function of s3c_i2sv2_probe. -No need to iounmap. Here, mapping done by devm_ioremap_resource. Signed-off-by: Arvind Yadav ---