Re: [PATCH] ASoC: tas2770: Fix snd_soc_update_bits error handling

2019-10-04 Thread Dan Murphy
Mark On 10/4/19 3:26 PM, Mark Brown wrote: On Fri, Oct 04, 2019 at 03:22:45PM -0500, Dan Murphy wrote: --- a/arch/arm/configs/omap2plus_defconfig +++ b/arch/arm/configs/omap2plus_defconfig @@ -395,6 +395,7 @@ CONFIG_SND_SOC_OMAP_ABE_TWL6040=m CONFIG_SND_SOC_OMAP_HDMI=m CONFIG_SND_SOC_CPCAP

Re: [PATCH] ASoC: tas2770: Fix snd_soc_update_bits error handling

2019-10-04 Thread Mark Brown
On Fri, Oct 04, 2019 at 03:22:45PM -0500, Dan Murphy wrote: > --- a/arch/arm/configs/omap2plus_defconfig > +++ b/arch/arm/configs/omap2plus_defconfig > @@ -395,6 +395,7 @@ CONFIG_SND_SOC_OMAP_ABE_TWL6040=m > CONFIG_SND_SOC_OMAP_HDMI=m > CONFIG_SND_SOC_CPCAP=m > CONFIG_SND_SOC_TLV320AIC23_I2C=m

[PATCH] ASoC: tas2770: Fix snd_soc_update_bits error handling

2019-10-04 Thread Dan Murphy
According the documentation for snd_soc_update_bits the API will return a 1 if the update was successful with a value change, a 0 if the update was successful with no value change or a negative if the command just failed. So the value of return in the driver needs to be checked for being less then