Re: [PATCH] ASoC: tegra_alc5632: fix device_node refcounting

On 27/07/18 22:06, Alexey Khoroshilov wrote: > tegra_alc5632_probe() increments reference count of device nodes > with of_parse_phandle(), but there is no code decrementing them > in the driver. > > The patch adds of_node_put() to tegra_alc5632_remove() and > to error handling paths in the probe

Re: [PATCH] ASoC: tegra_alc5632: fix device_node refcounting

Hello Alexey, AFAICT, this looks right. It seems that *most* of the machine drivers (not only tegra) forget to decrease the refcount. I'm wondering why you didn't sent a series patch to fix them all at once? Reviewed-by: Marc Dietrich Marc On Sat, 28 Jul 2018, Alexey Khoroshilov wrote: t

[PATCH] ASoC: tegra_alc5632: fix device_node refcounting

tegra_alc5632_probe() increments reference count of device nodes with of_parse_phandle(), but there is no code decrementing them in the driver. The patch adds of_node_put() to tegra_alc5632_remove() and to error handling paths in the probe. Found by Linux Driver Verification project (linuxtesting