Re: [PATCH] Add CHARGE_NOW support to cw2015_battery.c

2021-02-16 Thread Tobias Schramm
Hi Martin, thanks for the patch. Looks good and tests fine. eh, scratch that. Didn't have my cup of morning coffee yet. The patch is fine as far as the code change goes. However it is missing a "Signed-off-by" line, certifying your authorship. git can generate that automagically for you wit

Re: [PATCH] Add CHARGE_NOW support to cw2015_battery.c

2021-02-16 Thread Tobias Schramm
Hi Martin, thanks for the patch. Looks good and tests fine. CHARGE_NOW is expected by some user software (such as waybar) instead of 'CAPACITY', in order to correctly calculate remaining battery life. --- drivers/power/supply/cw2015_battery.c | 6 ++ 1 file changed, 6 insertions(+) dif