Re: [PATCH] Add ENOSYS into sys_io_cancel

2005-07-12 Thread Benjamin LaHaise
On Tue, Jul 12, 2005 at 11:49:47AM -0400, Wendy Cheng wrote: > Didn't realize the patch was sent to linux-kernel (that I don't > subscribe) instead of linux-aio - revised patch attached. Thanks for the > help Wendy Okay, applied. Thanks! -ben - To unsubscribe from this lis

Re: [PATCH] Add ENOSYS into sys_io_cancel

2005-07-12 Thread Wendy Cheng
Benjamin LaHaise wrote: Also, please cc [EMAIL PROTECTED] on future aio patches. Didn't realize the patch was sent to linux-kernel (that I don't subscribe) instead of linux-aio - revised patch attached. Thanks for the help Wendy On Mon, Jul 11, 2005 at 03:06:52PM -0400, Wendy Cheng

Re: [PATCH] Add ENOSYS into sys_io_cancel

2005-07-11 Thread Benjamin LaHaise
Hello Wendy, Two things: your patch needs to be properly signed off on. Read Documentation/SubmittingPatches for a description of what that entials. Secondly, your patch adds whitespace on the end of the else. Aside from that, the printk should be removed -- just replace it with the ret = -

[PATCH] Add ENOSYS into sys_io_cancel

2005-07-11 Thread Wendy Cheng
Previously sent via private mail that doesn't seem to go thru - resend via office mailer. Note that other than few exceptions, most of the current filesystem and/or drivers do not have aio cancel specifically defined (kiob->ki_cancel field is mostly NULL). However, sys_io_cancel system call u

[PATCH] Add ENOSYS into sys_io_cancel

2005-07-10 Thread Shiow-wen Cheng
Other than few exceptions (e.g. usb/gadget), none of the current filesystems and/or drivers that has io_cancel implemented (kiocb->ki_cancel left with NULL). However, the io_cancel() system call (sys_io_cancel) somehow universally sets return code to -EAGAIN. This gives us a false impression that i