Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-09-10 Thread Guillaume Chazarain
Le Fri, 7 Sep 2007 16:37:57 -0700 (PDT), Jonathan Lim <[EMAIL PROTECTED]> a écrit : > > Excellent, so can Guillaume change ac_btime to be just > > tsk->start_time? > > I don't think so. Current time (xtime) is relative to the epoch; > uptime and tsk->start_time (jiffies) are both relative to som

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-09-07 Thread Jonathan Lim
On Fri Aug 31 00:24:47 2007, [EMAIL PROTECTED] wrote: > > Jonathan Lim wrote: > > On Sat Aug 25 21:58:44 2007, [EMAIL PROTECTED] wrote: > >>> Also, I don't understand why the code to update btime: > >>> > >>> /* calculate task elapsed time in timespec */ > >>> do_posix_clock_monoto

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-31 Thread Balbir Singh
Jonathan Lim wrote: > On Sat Aug 25 21:58:44 2007, [EMAIL PROTECTED] wrote: >>> Also, I don't understand why the code to update btime: >>> >>> /* calculate task elapsed time in timespec */ >>> do_posix_clock_monotonic_gettime(&uptime); >>> ts = timespec_sub(uptime, tsk->star

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-30 Thread Jonathan Lim
On Sat Aug 25 21:58:44 2007, [EMAIL PROTECTED] wrote: > > > Also, I don't understand why the code to update btime: > > > > /* calculate task elapsed time in timespec */ > > do_posix_clock_monotonic_gettime(&uptime); > > ts = timespec_sub(uptime, tsk->start_time); > > .

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-26 Thread Guillaume Chazarain
Le Sun, 26 Aug 2007 10:28:44 +0530, Balbir Singh <[EMAIL PROTECTED]> a écrit : > From what I understand, task->start_time and task->real_start_time > are taken from the realtime clock. The accounting in CSA seems > to be very similar to the accounting done in do_acct_process() > (kernel/acct.c). >

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-25 Thread Balbir Singh
Guillaume Chazarain wrote: > Le Mon, 20 Aug 2007 22:31:08 +0530, > Balbir Singh <[EMAIL PROTECTED]> a écrit : > >>> --- a/kernel/taskstats.cSat Aug 18 17:15:17 2007 -0700 >>> +++ b/kernel/taskstats.cSun Aug 19 17:20:15 2007 +0200 >>> @@ -246,6 +246,8 @@ static int fill_tgid(pid_t tgid, str

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-25 Thread Guillaume Chazarain
Le Mon, 20 Aug 2007 22:31:08 +0530, Balbir Singh <[EMAIL PROTECTED]> a écrit : > > --- a/kernel/taskstats.cSat Aug 18 17:15:17 2007 -0700 > > +++ b/kernel/taskstats.cSun Aug 19 17:20:15 2007 +0200 > > @@ -246,6 +246,8 @@ static int fill_tgid(pid_t tgid, struct > > > > stats->

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-20 Thread Balbir Singh
Guillaume Chazarain wrote: > TASKSTATS_CMD_ATTR_TGID used to return only the delay accounting stats, > not the basic and extended accounting. With this patch, > TASKSTATS_CMD_ATTR_TGID returns also the min, max or sum (depending on > the semantic of the field) of the accounting info for all threads

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-19 Thread Guillaume Chazarain
TASKSTATS_CMD_ATTR_TGID used to return only the delay accounting stats, not the basic and extended accounting. With this patch, TASKSTATS_CMD_ATTR_TGID returns also the min, max or sum (depending on the semantic of the field) of the accounting info for all threads of a thread group. This makes TASK

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-15 Thread Balbir Singh
Guillaume Chazarain wrote: > [Resent with different recipients as [EMAIL PROTECTED] bounced with > a User unknown] > > Hi, > > This patch adds all thread accounting stats for the global tgid stats. > As a shameless plug, this fixes iotop -P > (http://guichaz.free.fr/misc/iotop.py). > Since thi

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-02 Thread Andrew Morton
On Thu, 2 Aug 2007 15:53:13 +0200 "Guillaume Chazarain" <[EMAIL PROTECTED]> wrote: > [Resent with different recipients as [EMAIL PROTECTED] bounced with > a User unknown] > > Hi, > > This patch adds all thread accounting stats for the global tgid stats. > As a shameless plug, this fixes iotop -P

[PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-02 Thread Guillaume Chazarain
[Resent with different recipients as [EMAIL PROTECTED] bounced with a User unknown] Hi, This patch adds all thread accounting stats for the global tgid stats. As a shameless plug, this fixes iotop -P (http://guichaz.free.fr/misc/iotop.py). Signed-off-by: Guillaume Chazarain <[EMAIL PROTECTED]> -

[PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-02 Thread Guillaume Chazarain
Hi, This patch adds all thread accounting stats for the global tgid stats. As a shameless plug, this fixes iotop -P (http://guichaz.free.fr/misc/iotop.py). Signed-off-by: Guillaume Chazarain <[EMAIL PROTECTED]> --- diff -r 22708012ca6e kernel/taskstats.c --- a/kernel/taskstats.cTue Jul 3