Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mark Brown
On Thu, Oct 30, 2014 at 12:31:42PM +0100, Mike Looijmans wrote: > On 10/30/2014 11:58 AM, Mark Brown wrote: > >>Hmm, I looked into doing that, but that isn't trivial, and too many devices > >>will suffer. > >Why would this have a negative effect on other devices? Unless somehow > >the other

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mike Looijmans
On 10/30/2014 11:58 AM, Mark Brown wrote: On Thu, Oct 30, 2014 at 11:53:37AM +0100, Mike Looijmans wrote: On 10/30/2014 11:29 AM, Mike Looijmans wrote: So I should add "regulator-default-voltage" to the generic code? That would indeed be better than trying to do it into this driver. But

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mark Brown
On Thu, Oct 30, 2014 at 11:53:37AM +0100, Mike Looijmans wrote: > On 10/30/2014 11:29 AM, Mike Looijmans wrote: > >So I should add "regulator-default-voltage" to the generic code? That would > >indeed be better than trying to do it into this driver. > >But would that need a separate patch for

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mike Looijmans
On 10/30/2014 11:29 AM, Mike Looijmans wrote: On 10/30/2014 11:15 AM, Mark Brown wrote: On Thu, Oct 30, 2014 at 07:47:44AM +0100, Mike Looijmans wrote: On 10/29/2014 01:30 PM, Mark Brown wrote: A couple of problems here: - This contains DT code but no DT bindings documentation; the

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mike Looijmans
On 10/30/2014 11:15 AM, Mark Brown wrote: On Thu, Oct 30, 2014 at 07:47:44AM +0100, Mike Looijmans wrote: On 10/29/2014 01:30 PM, Mark Brown wrote: A couple of problems here: - This contains DT code but no DT bindings documentation; the binding documentation is mandatory for any

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mark Brown
On Thu, Oct 30, 2014 at 07:47:44AM +0100, Mike Looijmans wrote: > On 10/29/2014 01:30 PM, Mark Brown wrote: > >A couple of problems here: > > - This contains DT code but no DT bindings documentation; the binding > >documentation is mandatory for any new bindings. > Should I submit a new

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mike Looijmans
On 10/29/2014 01:30 PM, Mark Brown wrote: On Wed, Oct 29, 2014 at 09:16:00AM +0100, Mike Looijmans wrote: + if (!status->voltage_set) { + if (of_property_read_u32(dev->dev.of_node, + "ltc3562-default-voltage", _default) == 0) { A couple of problems

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mike Looijmans
On 10/29/2014 01:30 PM, Mark Brown wrote: On Wed, Oct 29, 2014 at 09:16:00AM +0100, Mike Looijmans wrote: + if (!status-voltage_set) { + if (of_property_read_u32(dev-dev.of_node, + ltc3562-default-voltage, v_default) == 0) { A couple of problems

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mark Brown
On Thu, Oct 30, 2014 at 07:47:44AM +0100, Mike Looijmans wrote: On 10/29/2014 01:30 PM, Mark Brown wrote: A couple of problems here: - This contains DT code but no DT bindings documentation; the binding documentation is mandatory for any new bindings. Should I submit a new patch to

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mike Looijmans
On 10/30/2014 11:15 AM, Mark Brown wrote: On Thu, Oct 30, 2014 at 07:47:44AM +0100, Mike Looijmans wrote: On 10/29/2014 01:30 PM, Mark Brown wrote: A couple of problems here: - This contains DT code but no DT bindings documentation; the binding documentation is mandatory for any

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mike Looijmans
On 10/30/2014 11:29 AM, Mike Looijmans wrote: On 10/30/2014 11:15 AM, Mark Brown wrote: On Thu, Oct 30, 2014 at 07:47:44AM +0100, Mike Looijmans wrote: On 10/29/2014 01:30 PM, Mark Brown wrote: A couple of problems here: - This contains DT code but no DT bindings documentation; the

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mark Brown
On Thu, Oct 30, 2014 at 11:53:37AM +0100, Mike Looijmans wrote: On 10/30/2014 11:29 AM, Mike Looijmans wrote: So I should add regulator-default-voltage to the generic code? That would indeed be better than trying to do it into this driver. But would that need a separate patch for regulator

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mike Looijmans
On 10/30/2014 11:58 AM, Mark Brown wrote: On Thu, Oct 30, 2014 at 11:53:37AM +0100, Mike Looijmans wrote: On 10/30/2014 11:29 AM, Mike Looijmans wrote: So I should add regulator-default-voltage to the generic code? That would indeed be better than trying to do it into this driver. But

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-30 Thread Mark Brown
On Thu, Oct 30, 2014 at 12:31:42PM +0100, Mike Looijmans wrote: On 10/30/2014 11:58 AM, Mark Brown wrote: Hmm, I looked into doing that, but that isn't trivial, and too many devices will suffer. Why would this have a negative effect on other devices? Unless somehow the other devices add

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-29 Thread Mark Brown
On Wed, Oct 29, 2014 at 09:16:00AM +0100, Mike Looijmans wrote: > + if (!status->voltage_set) { > + if (of_property_read_u32(dev->dev.of_node, > + "ltc3562-default-voltage", _default) == 0) { A couple of problems here: - This contains DT code but no DT

[PATCH] Add ltc3562 voltage regulator driver

2014-10-29 Thread Mike Looijmans
The ltc3562 is an I2C controlled regulator supporting 4 independent outputs. Signed-off-by: Mike Looijmans --- drivers/regulator/Kconfig |7 + drivers/regulator/Makefile |1 + drivers/regulator/ltc3562.c | 387 +++ 3 files changed, 395

[PATCH] Add ltc3562 voltage regulator driver

2014-10-29 Thread Mike Looijmans
The ltc3562 is an I2C controlled regulator supporting 4 independent outputs. Signed-off-by: Mike Looijmans mike.looijm...@topic.nl --- drivers/regulator/Kconfig |7 + drivers/regulator/Makefile |1 + drivers/regulator/ltc3562.c | 387 +++ 3

Re: [PATCH] Add ltc3562 voltage regulator driver

2014-10-29 Thread Mark Brown
On Wed, Oct 29, 2014 at 09:16:00AM +0100, Mike Looijmans wrote: + if (!status-voltage_set) { + if (of_property_read_u32(dev-dev.of_node, + ltc3562-default-voltage, v_default) == 0) { A couple of problems here: - This contains DT code but no DT bindings