Re: [PATCH] Add missing KERN_ to multiline printk(KERN_...)

2007-08-09 Thread Lennert Buytenhek
On Wed, Aug 08, 2007 at 05:28:46PM -0700, Joe Perches wrote: > Some uses of printk are missing KERN_ on the second > and subsequent lines. I'm not the ARM maintainer, but for what it's worth, the arch/arm/kernel/ecard.c change looks fine to me. Acked-by: Lennert Buytenhek <[EMAIL PROTECTED]> - T

Re: [PATCH] Add missing KERN_ to multiline printk(KERN_...)

2007-08-09 Thread Ralf Baechle
On Wed, Aug 08, 2007 at 05:28:46PM -0700, Joe Perches wrote: > Some uses of printk are missing KERN_ on the second > and subsequent lines. > > For instance: > > printk(KERN_INFO "line1: %d\nline2: %d\n", val1, val2); > > Line1 is marked log_level: info > Line2 is marked log_level: unknown > >

Re: [PATCH] Add missing KERN_ to multiline printk(KERN_...)

2007-08-08 Thread Grant Grundler
On Wed, Aug 08, 2007 at 05:28:46PM -0700, Joe Perches wrote: > Some uses of printk are missing KERN_ on the second > and subsequent lines. Nice! Thanks! ACK the three parisc-linux bits. thanks, grant > > For instance: > > printk(KERN_INFO "line1: %d\nline2: %d\n", val1, val2); > > Line1 is m

[PATCH] Add missing KERN_ to multiline printk(KERN_...)

2007-08-08 Thread Joe Perches
Some uses of printk are missing KERN_ on the second and subsequent lines. For instance: printk(KERN_INFO "line1: %d\nline2: %d\n", val1, val2); Line1 is marked log_level: info Line2 is marked log_level: unknown Some lines have trailing spaces after \n, removed where appropriate. Signed-off-by: