On 07/13/2012 12:04 PM, Mike Waychison wrote:
You can probably save the wrap by copying out var->Attributes into a local.
Yes, you are right. It will work in this case. I am considering the general
case of very long name for a constant causing issues with line wrap in
more complex code, or jus
On 07/13/2012 11:54 AM, Matthew Garrett wrote:
On Fri, Jul 13, 2012 at 11:52:15AM -0600, Khalid Aziz wrote:
EFI_VARIABLE_NON_VOLATILE -> EFI_VAR_NV
EFI_VARIABLE_BOOTSERVICE_ACCESS -> EFI_VAR_BOOT
EFI_VARIABLE_RUNTIME_ACCESS -> EFI_VAR_RUN
On Fri, Jul 13, 2012 at 11:52:15AM -0600, Khalid Aziz wrote:
> EFI_VARIABLE_NON_VOLATILE -> EFI_VAR_NV
> EFI_VARIABLE_BOOTSERVICE_ACCESS -> EFI_VAR_BOOT
> EFI_VARIABLE_RUNTIME_ACCESS -> EFI_VAR_RUNTIME
> EFI_VARIABLE_HARDWARE_ERROR_RECORD
On 07/13/2012 09:46 AM, Matthew Garrett wrote:
I know you're just following the pattern of the existing code, but could
you change these to be more like
if (var->Attributes & EFI_VARIABLE_RUNTIME_ACCESS)
while you're at it? I think that'd be a worthwhile cleanup.
I just sent out an updated p
On 07/13/2012 09:46 AM, Matthew Garrett wrote:
On Fri, Jul 13, 2012 at 09:38:27AM -0600, Khalid Aziz wrote:
if (var->Attributes & 0x4)
str += sprintf(str, "EFI_VARIABLE_RUNTIME_ACCESS\n");
I know you're just following the pattern of the existing code, but could
you chang
On Fri, Jul 13, 2012 at 09:38:27AM -0600, Khalid Aziz wrote:
> if (var->Attributes & 0x4)
> str += sprintf(str, "EFI_VARIABLE_RUNTIME_ACCESS\n");
I know you're just following the pattern of the existing code, but could
you change these to be more like
if (var->Attributes & EF
On Fri, Jul 13, 2012 at 10:38 AM, Khalid Aziz wrote:
> Some of the EFI variable attributes are missing from print out from
> /sys/firmware/efi/vars/*/attributes. This patch adds those in.
>
> Signed-off-by: Khalid Aziz
> Cc: sta...@vger.kernel.org
Seems good to me.
Reviewed-by: Kees Cook
--
Some of the EFI variable attributes are missing from print out from
/sys/firmware/efi/vars/*/attributes. This patch adds those in.
Signed-off-by: Khalid Aziz
Cc: sta...@vger.kernel.org
---
drivers/firmware/efivars.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/firmwa
8 matches
Mail list logo
