Re: [PATCH] Add slowpath enter/exit trace events

2017-11-24 Thread peter enderborg
On 11/23/2017 03:01 PM, Michal Hocko wrote: > I am not sure adding a probe on a production system will fly in many > cases. A static tracepoint would be much easier in that case. But I > agree there are other means to accomplish the same thing. My main point > was to have an easy out-of-the-box

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-24 Thread peter enderborg
On 11/23/2017 03:01 PM, Michal Hocko wrote: > I am not sure adding a probe on a production system will fly in many > cases. A static tracepoint would be much easier in that case. But I > agree there are other means to accomplish the same thing. My main point > was to have an easy out-of-the-box

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread peter enderborg
On 11/23/2017 02:43 PM, Tetsuo Handa wrote: > Please see my attempt at > http://lkml.kernel.org/r/1510833448-19918-1-git-send-email-penguin-ker...@i-love.sakura.ne.jp > . > Printing just current thread is not sufficient for me. > > Seems to  me that it is a lot more overhead with timers and

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread peter enderborg
On 11/23/2017 02:43 PM, Tetsuo Handa wrote: > Please see my attempt at > http://lkml.kernel.org/r/1510833448-19918-1-git-send-email-penguin-ker...@i-love.sakura.ne.jp > . > Printing just current thread is not sufficient for me. > > Seems to  me that it is a lot more overhead with timers and

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Mel Gorman
On Thu, Nov 23, 2017 at 03:01:27PM +0100, Michal Hocko wrote: > On Thu 23-11-17 13:36:29, Mel Gorman wrote: > > On Thu, Nov 23, 2017 at 01:25:30PM +0100, Michal Hocko wrote: > > > On Thu 23-11-17 11:43:36, peter.enderb...@sony.com wrote: > > > > From: Peter Enderborg > >

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Mel Gorman
On Thu, Nov 23, 2017 at 03:01:27PM +0100, Michal Hocko wrote: > On Thu 23-11-17 13:36:29, Mel Gorman wrote: > > On Thu, Nov 23, 2017 at 01:25:30PM +0100, Michal Hocko wrote: > > > On Thu 23-11-17 11:43:36, peter.enderb...@sony.com wrote: > > > > From: Peter Enderborg > > > > > > > > The warning

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Michal Hocko
On Thu 23-11-17 13:36:29, Mel Gorman wrote: > On Thu, Nov 23, 2017 at 01:25:30PM +0100, Michal Hocko wrote: > > On Thu 23-11-17 11:43:36, peter.enderb...@sony.com wrote: > > > From: Peter Enderborg > > > > > > The warning of slow allocation has been removed, this is > >

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Michal Hocko
On Thu 23-11-17 13:36:29, Mel Gorman wrote: > On Thu, Nov 23, 2017 at 01:25:30PM +0100, Michal Hocko wrote: > > On Thu 23-11-17 11:43:36, peter.enderb...@sony.com wrote: > > > From: Peter Enderborg > > > > > > The warning of slow allocation has been removed, this is > > > a other way to fetch

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Michal Hocko
On Thu 23-11-17 14:03:04, peter enderborg wrote: > On 11/23/2017 01:47 PM, Michal Hocko wrote: > > > > This might be true but the other POV is that the trace point with the > > additional information is just too disruptive to the rest of the code > > and it exposes too many implementation details.

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Michal Hocko
On Thu 23-11-17 14:03:04, peter enderborg wrote: > On 11/23/2017 01:47 PM, Michal Hocko wrote: > > > > This might be true but the other POV is that the trace point with the > > additional information is just too disruptive to the rest of the code > > and it exposes too many implementation details.

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Mel Gorman
On Thu, Nov 23, 2017 at 01:25:30PM +0100, Michal Hocko wrote: > On Thu 23-11-17 11:43:36, peter.enderb...@sony.com wrote: > > From: Peter Enderborg > > > > The warning of slow allocation has been removed, this is > > a other way to fetch that information. But you need >

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Mel Gorman
On Thu, Nov 23, 2017 at 01:25:30PM +0100, Michal Hocko wrote: > On Thu 23-11-17 11:43:36, peter.enderb...@sony.com wrote: > > From: Peter Enderborg > > > > The warning of slow allocation has been removed, this is > > a other way to fetch that information. But you need > > to enable the trace.

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Tetsuo Handa
On 2017/11/23 22:36, Mel Gorman wrote: > On Thu, Nov 23, 2017 at 01:25:30PM +0100, Michal Hocko wrote: >> On Thu 23-11-17 11:43:36, peter.enderb...@sony.com wrote: >>> From: Peter Enderborg >>> >>> The warning of slow allocation has been removed, this is >>> a other way

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Tetsuo Handa
On 2017/11/23 22:36, Mel Gorman wrote: > On Thu, Nov 23, 2017 at 01:25:30PM +0100, Michal Hocko wrote: >> On Thu 23-11-17 11:43:36, peter.enderb...@sony.com wrote: >>> From: Peter Enderborg >>> >>> The warning of slow allocation has been removed, this is >>> a other way to fetch that information.

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread peter enderborg
On 11/23/2017 01:47 PM, Michal Hocko wrote: > > This might be true but the other POV is that the trace point with the > additional information is just too disruptive to the rest of the code > and it exposes too many implementation details. >From who do you want to hide details? Is this a security

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread peter enderborg
On 11/23/2017 01:47 PM, Michal Hocko wrote: > > This might be true but the other POV is that the trace point with the > additional information is just too disruptive to the rest of the code > and it exposes too many implementation details. >From who do you want to hide details? Is this a security

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Tetsuo Handa
On 2017/11/23 19:43, peter.enderb...@sony.com wrote: > The warning of slow allocation has been removed, this is > a other way to fetch that information. But you need > to enable the trace. The exit function also returns > information about the number of retries, how long > it was stalled and

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Tetsuo Handa
On 2017/11/23 19:43, peter.enderb...@sony.com wrote: > The warning of slow allocation has been removed, this is > a other way to fetch that information. But you need > to enable the trace. The exit function also returns > information about the number of retries, how long > it was stalled and

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Michal Hocko
On Thu 23-11-17 13:35:15, peter enderborg wrote: > Monitoring both enter/exit for all allocations and track down the one > that are slow will be a very big load on mobile devices or embedded > device consuming a lot of battery and cpu. With this we can do useful > monitoring on devices on our

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Michal Hocko
On Thu 23-11-17 13:35:15, peter enderborg wrote: > Monitoring both enter/exit for all allocations and track down the one > that are slow will be a very big load on mobile devices or embedded > device consuming a lot of battery and cpu. With this we can do useful > monitoring on devices on our

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread peter enderborg
Monitoring both enter/exit for all allocations and track down the one that are slow will be a very big load on mobile devices or embedded device consuming a lot of battery and cpu. With this we can do useful monitoring on devices on our field tests with real usage. On 11/23/2017 01:25 PM,

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread peter enderborg
Monitoring both enter/exit for all allocations and track down the one that are slow will be a very big load on mobile devices or embedded device consuming a lot of battery and cpu. With this we can do useful monitoring on devices on our field tests with real usage. On 11/23/2017 01:25 PM,

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Michal Hocko
On Thu 23-11-17 11:43:36, peter.enderb...@sony.com wrote: > From: Peter Enderborg > > The warning of slow allocation has been removed, this is > a other way to fetch that information. But you need > to enable the trace. The exit function also returns > information about

Re: [PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread Michal Hocko
On Thu 23-11-17 11:43:36, peter.enderb...@sony.com wrote: > From: Peter Enderborg > > The warning of slow allocation has been removed, this is > a other way to fetch that information. But you need > to enable the trace. The exit function also returns > information about the number of retries,

[PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread peter.enderborg
From: Peter Enderborg The warning of slow allocation has been removed, this is a other way to fetch that information. But you need to enable the trace. The exit function also returns information about the number of retries, how long it was stalled and failure reason if

[PATCH] Add slowpath enter/exit trace events

2017-11-23 Thread peter.enderborg
From: Peter Enderborg The warning of slow allocation has been removed, this is a other way to fetch that information. But you need to enable the trace. The exit function also returns information about the number of retries, how long it was stalled and failure reason if that happened.