Re: [PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-08-01 Thread Nick Krause
On Fri, Aug 1, 2014 at 8:21 AM, Theodore Ts'o wrote: > On Thu, Jul 31, 2014 at 08:09:10PM +0100, Hugo Mills wrote: >> On Thu, Jul 31, 2014 at 01:53:33PM -0400, Nicholas Krause wrote: >> > This adds checks for the stated modes as if they are crap we will return >> > error >> > not supported. >> >>

Re: [PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-08-01 Thread Theodore Ts'o
On Thu, Jul 31, 2014 at 08:09:10PM +0100, Hugo Mills wrote: > On Thu, Jul 31, 2014 at 01:53:33PM -0400, Nicholas Krause wrote: > > This adds checks for the stated modes as if they are crap we will return > > error > > not supported. > >You've just enabled two options, but you haven't actually

Re: [PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-08-01 Thread Hugo Mills
On Thu, Jul 31, 2014 at 09:53:15PM -0400, Nick Krause wrote: > On Thu, Jul 31, 2014 at 3:09 PM, Hugo Mills wrote: > > On Thu, Jul 31, 2014 at 01:53:33PM -0400, Nicholas Krause wrote: > >> This adds checks for the stated modes as if they are crap we will return > >> error > >> not supported. > > >

Re: [PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-07-31 Thread Nick Krause
On Thu, Jul 31, 2014 at 3:09 PM, Hugo Mills wrote: > On Thu, Jul 31, 2014 at 01:53:33PM -0400, Nicholas Krause wrote: >> This adds checks for the stated modes as if they are crap we will return >> error >> not supported. > >You've just enabled two options, but you haven't actually > implement

Re: [PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-07-31 Thread Duncan
Nicholas Krause posted on Thu, 31 Jul 2014 13:53:33 -0400 as excerpted: > This adds checks for the stated modes as if they are crap we will return > error not supported. > > Signed-off-by: Nicholas Krause > --- > fs/btrfs/file.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

Re: [PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-07-31 Thread Hugo Mills
On Thu, Jul 31, 2014 at 01:53:33PM -0400, Nicholas Krause wrote: > This adds checks for the stated modes as if they are crap we will return error > not supported. You've just enabled two options, but you haven't actually implemented the code behind it. I would tell you *NOT* to do anything else

[PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-07-31 Thread Nicholas Krause
This adds checks for the stated modes as if they are crap we will return error not supported. Signed-off-by: Nicholas Krause --- fs/btrfs/file.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 1f2b99c..599495a 100644 --- a/fs/btrfs