Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-12 Thread Stelian Pop
Le mardi 12 juillet 2005 à 20:13 +0200, Vojtech Pavlik a écrit : > Stelian, can you please update the patch to use usb_to_input_id()? It'll > go through -mm first, anyway, so there shouldn't be any issue with > Linus's kernels not having that function yet. Sure, here it comes. Stelian. Changes:

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-12 Thread Vojtech Pavlik
On Tue, Jul 12, 2005 at 09:47:16AM -0500, Dmitry Torokhov wrote: > On 7/12/05, Stelian Pop <[EMAIL PROTECTED]> wrote: > > Le mardi 12 juillet 2005 ? 09:13 -0500, Dmitry Torokhov a écrit : > > > Hi, > > > > > > On 7/12/05, Stelian Pop <[EMAIL PROTECTED]> wrote: > > > > > > > > + dev->input.id.

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-12 Thread Dmitry Torokhov
On 7/12/05, Stelian Pop <[EMAIL PROTECTED]> wrote: > Le mardi 12 juillet 2005 à 09:13 -0500, Dmitry Torokhov a écrit : > > Hi, > > > > On 7/12/05, Stelian Pop <[EMAIL PROTECTED]> wrote: > > > > > > + dev->input.id.bustype = BUS_USB; > > > + dev->input.id.vendor = id->idVendor; > > > +

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-12 Thread Stelian Pop
Le mardi 12 juillet 2005 à 09:13 -0500, Dmitry Torokhov a écrit : > Hi, > > On 7/12/05, Stelian Pop <[EMAIL PROTECTED]> wrote: > > > > + dev->input.id.bustype = BUS_USB; > > + dev->input.id.vendor = id->idVendor; > > + dev->input.id.product = id->idProduct; > > + dev->input

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-12 Thread Dmitry Torokhov
Hi, On 7/12/05, Stelian Pop <[EMAIL PROTECTED]> wrote: > > + dev->input.id.bustype = BUS_USB; > + dev->input.id.vendor = id->idVendor; > + dev->input.id.product = id->idProduct; > + dev->input.id.version = ATP_DRIVER_VERSION; > + Why don't we do what most of the other inpu

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-12 Thread Stelian Pop
Le lundi 11 juillet 2005 à 13:21 +0200, Vojtech Pavlik a écrit : > > > This could be quite useful, too, for right and middle button taps (2 and > > > 3 fingers) - since the Macs lack these buttons. > > > > Indeed. But this can be a later improvement, let's make one finger work > > for now :) Tha

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Stelian Pop
Le lundi 11 juillet 2005 à 16:44 -0400, Lee Revell a écrit : > On Mon, 2005-07-11 at 13:04 +0200, Stelian Pop wrote: > > Oops, bad Evolution (even if I did use insert->text file for the patch). > > > > Going back to mutt. Sorry about this. > > There's no need to go back to mutt, Evolution is not

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Lee Revell
On Mon, 2005-07-11 at 13:04 +0200, Stelian Pop wrote: > Oops, bad Evolution (even if I did use insert->text file for the patch). > > Going back to mutt. Sorry about this. There's no need to go back to mutt, Evolution is not broken. Before doing 'Insert->Text File', you just have to change the te

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Peter Osterlund
Stelian Pop <[EMAIL PROTECTED]> writes: > +/* > + * Smooth the data sequence by estimating the slope for the data sequence > + * [x3, x2, x1, x0] by using linear regression to fit a line to the data and > + * use the slope of the line. Taken from the synaptics X driver. > + */ This comment is not

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Peter Osterlund
Stelian Pop <[EMAIL PROTECTED]> writes: > Le lundi 11 juillet 2005 à 02:15 +0200, Peter Osterlund a écrit : > > Vojtech Pavlik <[EMAIL PROTECTED]> writes: > > > > > Using a function like > > > > > > return (x_old * 3 + x) / 4; > > > > > > eliminates the need for a FIFO, and has similar (if

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Stelian Pop
Le lundi 11 juillet 2005 à 14:47 +0200, Stelian Pop a écrit : > How to make it work ? Obviously I could implement either fuzz > elimination or smoothing in the driver, and leave the other > transformation to the input core (today it is the smoothing which is in > the driver, but doing it the other

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Stelian Pop
Le lundi 11 juillet 2005 à 13:21 +0200, Vojtech Pavlik a écrit : > On Mon, Jul 11, 2005 at 01:08:35PM +0200, Stelian Pop wrote: > > > Possible. The 'fuzz' parameter in input core serves too many usages > > ihmo. Let me try removing the quick motion compensation and see... > > It was designed for

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Vojtech Pavlik
On Mon, Jul 11, 2005 at 01:08:35PM +0200, Stelian Pop wrote: > Possible. The 'fuzz' parameter in input core serves too many usages > ihmo. Let me try removing the quick motion compensation and see... It was designed for joysticks and works very well for them. Usefulness for other device types may

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Stelian Pop
Le lundi 11 juillet 2005 à 13:00 +0200, Vojtech Pavlik a écrit : > On Mon, Jul 11, 2005 at 12:39:31PM +0200, Stelian Pop wrote: > > > > > Using a function like > > > > > > > > return (x_old * 3 + x) / 4; > > > > > > > > eliminates the need for a FIFO, and has similar (if not better) > >

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Stelian Pop
On Mon, Jul 11, 2005 at 03:52:44AM -0700, Andrew Morton wrote: > Stelian Pop <[EMAIL PROTECTED]> wrote: > > > > Anyway, here is the updated patch: > > > > Signed-off-by: Stelian Pop <[EMAIL PROTECTED]> > > > > Documentation/input/appletouch.txt | 83 ++ > > drivers/usb/input/Kconfig

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Vojtech Pavlik
On Mon, Jul 11, 2005 at 12:39:31PM +0200, Stelian Pop wrote: > > > Using a function like > > > > > > return (x_old * 3 + x) / 4; > > > > > > eliminates the need for a FIFO, and has similar (if not better) > > > properties to floating average, because its coefficients are > > > [ .25 .18 .14 .

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Vojtech Pavlik
On Mon, Jul 11, 2005 at 02:15:49AM +0200, Peter Osterlund wrote: > I took the liberty to modify the patch myself, making these changes: > > * Removed the extra filtering. > * Converted the "open" counter to an "open" flag. (It is still needed > by the atp_resume() function.) > * CodingStyle fix

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Stelian Pop
Le lundi 11 juillet 2005 à 02:15 +0200, Peter Osterlund a écrit : > Vojtech Pavlik <[EMAIL PROTECTED]> writes: > > > On Sun, Jul 10, 2005 at 12:48:30AM +0200, Peter Osterlund wrote: > > > Vojtech Pavlik <[EMAIL PROTECTED]> writes: > > > > > > > Btw, what I don't completely understand is why you n

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-11 Thread Stelian Pop
Le dimanche 10 juillet 2005 à 00:32 +0200, Peter Osterlund a écrit : > Stelian Pop <[EMAIL PROTECTED]> writes: > > > +Synaptics re-detection problems: > > + > > + > > +The synaptics X11 driver tries to re-open the touchpad input device file > > +(/dev/input/eventX)

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-10 Thread Peter Osterlund
Vojtech Pavlik <[EMAIL PROTECTED]> writes: > On Sun, Jul 10, 2005 at 12:48:30AM +0200, Peter Osterlund wrote: > > Vojtech Pavlik <[EMAIL PROTECTED]> writes: > > > > > Btw, what I don't completely understand is why you need linear > > > regression, when you're not trying to detect motion or someth

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-10 Thread Vojtech Pavlik
On Sun, Jul 10, 2005 at 12:48:30AM +0200, Peter Osterlund wrote: > Vojtech Pavlik <[EMAIL PROTECTED]> writes: > > > Btw, what I don't completely understand is why you need linear > > regression, when you're not trying to detect motion or something like > > that. Basic floating average, or even sim

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-10 Thread Vojtech Pavlik
On Sun, Jul 10, 2005 at 12:32:45AM +0200, Peter Osterlund wrote: > Stelian Pop <[EMAIL PROTECTED]> writes: > > > +Synaptics re-detection problems: > > + > > + > > +The synaptics X11 driver tries to re-open the touchpad input device file > > +(/dev/input/eventX) each

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-09 Thread Peter Osterlund
Vojtech Pavlik <[EMAIL PROTECTED]> writes: > Btw, what I don't completely understand is why you need linear > regression, when you're not trying to detect motion or something like > that. Basic floating average, or even simpler filtering like the input > core uses for fuzz could work well enough I

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-09 Thread Peter Osterlund
Stelian Pop <[EMAIL PROTECTED]> writes: > +Synaptics re-detection problems: > + > + > +The synaptics X11 driver tries to re-open the touchpad input device file > +(/dev/input/eventX) each time you change from text mode back to X11. If the > +input device file does n

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-09 Thread Vojtech Pavlik
On Fri, Jul 08, 2005 at 02:10:05PM +0200, Stelian Pop wrote: > On Fri, Jul 08, 2005 at 01:18:01PM +0200, Johannes Berg wrote: > > > Hi all, > > > > Nice to see this going into the kernel :) > > > > > This is a driver for the USB touchpad which can be found on > > > post-February 2005 Apple Power

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-08 Thread Stelian Pop
On Fri, Jul 08, 2005 at 01:18:01PM +0200, Johannes Berg wrote: > Hi all, > > Nice to see this going into the kernel :) > > > This is a driver for the USB touchpad which can be found on > > post-February 2005 Apple PowerBooks (PowerBook5,6). > > This is not perfectly correct, the PowerBook5,6 is

Re: [PATCH] Apple USB Touchpad driver (new)

2005-07-08 Thread Johannes Berg
Hi all, Nice to see this going into the kernel :) > This is a driver for the USB touchpad which can be found on > post-February 2005 Apple PowerBooks (PowerBook5,6). This is not perfectly correct, the PowerBook5,6 is afaik only the 15" model, the 12" and 17" have other numbers. Maybe you should

[PATCH] Apple USB Touchpad driver (new)

2005-07-08 Thread Stelian Pop
Hi, This is a driver for the USB touchpad which can be found on post-February 2005 Apple PowerBooks (PowerBook5,6). This driver is derived from Johannes Berg's appletrackpad driver [1], but it has been improved in some areas: * appletouch is a full kernel driver, no userspace program is neces