Re: [PATCH] BLK_DEV_IDE_CELLEB dependency fix

2007-03-15 Thread Benjamin Herrenschmidt
On Thu, 2007-03-15 at 17:30 +0300, Sergei Shtylyov wrote: > Hello. > > Akira Iguchi wrote: > > > It's bool and it depends on BLK_DEV_IDE > > => should depend on BLK_DEV_IDE=y > > Hm, why I'm seeing module_init() in the driver? :-) > > > And move it to "if BLK_DEV_IDEDMA_PCI" block because

Re: [PATCH] BLK_DEV_IDE_CELLEB dependency fix

2007-03-15 Thread Sergei Shtylyov
Hello. Akira Iguchi wrote: It's bool and it depends on BLK_DEV_IDE => should depend on BLK_DEV_IDE=y Hm, why I'm seeing module_init() in the driver? :-) And move it to "if BLK_DEV_IDEDMA_PCI" block because it depends on BLK_DEV_IDEDMA_PCI. IMHO, that driver shouldn't be in drivers/

[PATCH] BLK_DEV_IDE_CELLEB dependency fix

2007-03-14 Thread Akira Iguchi
It's bool and it depends on BLK_DEV_IDE => should depend on BLK_DEV_IDE=y And move it to "if BLK_DEV_IDEDMA_PCI" block because it depends on BLK_DEV_IDEDMA_PCI. Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> Signed-off-by: Akira Iguchi <[EMAIL PROTECT