Re: [PATCH] Bluetooth: Add NULL check for tiocmget() and tiocmset()

2019-01-30 Thread Myungho Jung
On Wed, Jan 30, 2019 at 10:59:38AM +0100, Johan Hovold wrote: > On Sun, Jan 27, 2019 at 10:59:13PM -0800, Myungho Jung wrote: > > tiocmget() and tiocmset() operations are optional and some tty drivers > > like pty miss the operations. We need NULL check before referencing > > them. > > Good catch.

Re: [PATCH] Bluetooth: Add NULL check for tiocmget() and tiocmset()

2019-01-30 Thread Johan Hovold
On Sun, Jan 27, 2019 at 10:59:13PM -0800, Myungho Jung wrote: > tiocmget() and tiocmset() operations are optional and some tty drivers > like pty miss the operations. We need NULL check before referencing > them. Good catch. I suggest splitting these fixes in two separate patches (after addressing

Re: [PATCH] Bluetooth: Add NULL check for tiocmget() and tiocmset()

2019-01-28 Thread Marcel Holtmann
Hi Myungho, > tiocmget() and tiocmset() operations are optional and some tty drivers > like pty miss the operations. We need NULL check before referencing > them. > > Reported-by: syzbot+a950165cbb86bdd02...@syzkaller.appspotmail.com > Signed-off-by: Myungho Jung > --- > drivers/bluetooth/hci_at

[PATCH] Bluetooth: Add NULL check for tiocmget() and tiocmset()

2019-01-27 Thread Myungho Jung
tiocmget() and tiocmset() operations are optional and some tty drivers like pty miss the operations. We need NULL check before referencing them. Reported-by: syzbot+a950165cbb86bdd02...@syzkaller.appspotmail.com Signed-off-by: Myungho Jung --- drivers/bluetooth/hci_ath.c | 13 - dr