Re: [PATCH] Bluetooth: Always call advertising disable before setting params

2021-03-24 Thread Daniel Winkler
Hello Marcel, Thank you for the feedback. I have just sent a V2 with a btmon snippet showing the HCI Set Advertising Parameters "Command Disallowed" failure that occurs as a result of this issue. I tried to provide some annotation for context. Please take a look. Thanks! Daniel On Wed, Mar 24,

Re: [PATCH] Bluetooth: Always call advertising disable before setting params

2021-03-24 Thread Marcel Holtmann
Hi Daniel, > In __hci_req_enable_advertising, the HCI_LE_ADV hdev flag is temporarily > cleared to allow the random address to be set, which exposes a race > condition when an advertisement is configured immediately (<10ms) after > software rotation starts to refresh an advertisement. > > In norm

[PATCH] Bluetooth: Always call advertising disable before setting params

2021-03-23 Thread Daniel Winkler
In __hci_req_enable_advertising, the HCI_LE_ADV hdev flag is temporarily cleared to allow the random address to be set, which exposes a race condition when an advertisement is configured immediately (<10ms) after software rotation starts to refresh an advertisement. In normal operation, the HCI_LE