Re: [PATCH] Bluetooth: hci_uart: Switch pty driver to slave side in tty_set_termios()

On Wed, Jan 30, 2019 at 09:13:53PM -0800, Myungho Jung wrote: > On Wed, Jan 30, 2019 at 11:07:38AM +0100, Johan Hovold wrote: > > On Sun, Jan 27, 2019 at 10:53:02PM -0800, Myungho Jung wrote: > > > tty_set_termios() should be called with slave side of pty driver. So, If > > > tty driver is pty mast

Re: [PATCH] Bluetooth: hci_uart: Switch pty driver to slave side in tty_set_termios()

On Wed, Jan 30, 2019 at 11:07:38AM +0100, Johan Hovold wrote: > On Sun, Jan 27, 2019 at 10:53:02PM -0800, Myungho Jung wrote: > > tty_set_termios() should be called with slave side of pty driver. So, If > > tty driver is pty master, it needs to be switched to ->link. > > I'm not sure that's the ri

Re: [PATCH] Bluetooth: hci_uart: Switch pty driver to slave side in tty_set_termios()

On Sun, Jan 27, 2019 at 10:53:02PM -0800, Myungho Jung wrote: > tty_set_termios() should be called with slave side of pty driver. So, If > tty driver is pty master, it needs to be switched to ->link. I'm not sure that's the right solution. PTYs are virtual devices used for IPC and neither end (mas

Re: [PATCH] Bluetooth: hci_uart: Switch pty driver to slave side in tty_set_termios()

Hi Myungho, > tty_set_termios() should be called with slave side of pty driver. So, If > tty driver is pty master, it needs to be switched to ->link. > > Reported-by: syzbot+a950165cbb86bdd02...@syzkaller.appspotmail.com > Signed-off-by: Myungho Jung > --- > drivers/bluetooth/hci_ldisc.c | 20 ++

[PATCH] Bluetooth: hci_uart: Switch pty driver to slave side in tty_set_termios()

tty_set_termios() should be called with slave side of pty driver. So, If tty driver is pty master, it needs to be switched to ->link. Reported-by: syzbot+a950165cbb86bdd02...@syzkaller.appspotmail.com Signed-off-by: Myungho Jung --- drivers/bluetooth/hci_ldisc.c | 20 +++- 1 file