Re: [PATCH] Bluetooth: hci_uart: check for missing tty operations in protocol handlers

2019-07-25 Thread Marcel Holtmann
Hi Vladis, >> why is this one hidden behind CONFIG_PM? The general baud rate changes are >> independent of runtime power management support. > > hci_bcm calls hci_uart_set_flow_control() only from functions hidden behind > #ifdef-CONFIG_PM (surely this can change in the future), and so without >

Re: [PATCH] Bluetooth: hci_uart: check for missing tty operations in protocol handlers

2019-07-25 Thread Vladis Dronov
Vladis Dronov" > Cc: "Johan Hedberg" , > linux-blueto...@vger.kernel.org, linux-kernel@vger.kernel.org, "Suraj > Sumangala" , "Frederic Danis" > , "Loic Poulain" > , "Balakrishna Godavarthi" , > syzkal...@googlegroups.com &

Re: [PATCH] Bluetooth: hci_uart: check for missing tty operations in protocol handlers

2019-07-25 Thread Marcel Holtmann
Hi Vladis, > Certain ttys operations (pty_unix98_ops) lack tiocmget() and tiocmset() > functions which are called by the certain HCI UART protocols (hci_ath, > hci_bcm, hci_intel, hci_mrvl, hci_qca) via hci_uart_set_flow_control() > or directly. This leads to an execution at NULL and can be trigge

[PATCH] Bluetooth: hci_uart: check for missing tty operations in protocol handlers

2019-07-25 Thread Vladis Dronov
Certain ttys operations (pty_unix98_ops) lack tiocmget() and tiocmset() functions which are called by the certain HCI UART protocols (hci_ath, hci_bcm, hci_intel, hci_mrvl, hci_qca) via hci_uart_set_flow_control() or directly. This leads to an execution at NULL and can be triggered by an unprivileg