Re: [PATCH] Btrfs: remove repeated eb->pages check in, disk-io.c/csum_dirty_buffer

2012-10-09 Thread Chris Mason
On Mon, Oct 08, 2012 at 07:26:15AM -0600, Wang Sheng-Hui wrote: > In csum_dirty_buffer, we first get eb from page->private. > Then we check if the page is the first page of eb. Later > we check it again. Remove the repeated check here. You had the right idea here, two checks and one has a

Re: [PATCH] Btrfs: remove repeated eb-pages check in, disk-io.c/csum_dirty_buffer

2012-10-09 Thread Chris Mason
On Mon, Oct 08, 2012 at 07:26:15AM -0600, Wang Sheng-Hui wrote: In csum_dirty_buffer, we first get eb from page-private. Then we check if the page is the first page of eb. Later we check it again. Remove the repeated check here. You had the right idea here, two checks and one has a warning, so

[PATCH] Btrfs: remove repeated eb->pages check in, disk-io.c/csum_dirty_buffer

2012-10-08 Thread Wang Sheng-Hui
In csum_dirty_buffer, we first get eb from page->private. Then we check if the page is the first page of eb. Later we check it again. Remove the repeated check here. Signed-off-by: Wang Sheng-Hui --- fs/btrfs/disk-io.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff

[PATCH] Btrfs: remove repeated eb-pages check in, disk-io.c/csum_dirty_buffer

2012-10-08 Thread Wang Sheng-Hui
In csum_dirty_buffer, we first get eb from page-private. Then we check if the page is the first page of eb. Later we check it again. Remove the repeated check here. Signed-off-by: Wang Sheng-Hui shh...@gmail.com --- fs/btrfs/disk-io.c |8 +++- 1 files changed, 3 insertions(+), 5