Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-20 Thread Arnd Bergmann
On Tue, Dec 19, 2017 at 10:21 PM, Long Li wrote: >> depends on CIFS && INFINIBAND >> + depends on CIFS=m || INFINIBAND=y > > How about we change them to > > depends on CIFS=m && INFINIBAND || CIFS=y && INFINIBAND=y > > This makes it easy to read. Yes, that

Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-20 Thread Arnd Bergmann
On Tue, Dec 19, 2017 at 10:21 PM, Long Li wrote: >> depends on CIFS && INFINIBAND >> + depends on CIFS=m || INFINIBAND=y > > How about we change them to > > depends on CIFS=m && INFINIBAND || CIFS=y && INFINIBAND=y > > This makes it easy to read. Yes, that seems fine. I would

Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Stefan Metzmacher
Am 19.12.2017 um 22:21 schrieb Long Li via samba-technical: >> depends on CIFS && INFINIBAND >> +depends on CIFS=m || INFINIBAND=y > > How about we change them to > > depends on CIFS=m && INFINIBAND || CIFS=y && INFINIBAND=y > > This makes it easy to read. I like it :-) metze

Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Stefan Metzmacher
Am 19.12.2017 um 22:21 schrieb Long Li via samba-technical: >> depends on CIFS && INFINIBAND >> +depends on CIFS=m || INFINIBAND=y > > How about we change them to > > depends on CIFS=m && INFINIBAND || CIFS=y && INFINIBAND=y > > This makes it easy to read. I like it :-) metze

RE: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Long Li
> depends on CIFS && INFINIBAND > + depends on CIFS=m || INFINIBAND=y How about we change them to depends on CIFS=m && INFINIBAND || CIFS=y && INFINIBAND=y This makes it easy to read.

RE: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Long Li
> depends on CIFS && INFINIBAND > + depends on CIFS=m || INFINIBAND=y How about we change them to depends on CIFS=m && INFINIBAND || CIFS=y && INFINIBAND=y This makes it easy to read.

Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Jean Delvare
On Tue, 19 Dec 2017 11:12:57 +0100, Arnd Bergmann wrote: > A built-in SMB file system cannot link against a modular > infiniband core module: > > fs/cifs/smbdirect.o: In function `smbd_destroy_rdma_work': > smbdirect.c:(.text+0x28e3): undefined reference to `ib_drain_qp' >

Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Jean Delvare
On Tue, 19 Dec 2017 11:12:57 +0100, Arnd Bergmann wrote: > A built-in SMB file system cannot link against a modular > infiniband core module: > > fs/cifs/smbdirect.o: In function `smbd_destroy_rdma_work': > smbdirect.c:(.text+0x28e3): undefined reference to `ib_drain_qp' >

Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Stefan Metzmacher
Am 19.12.2017 um 11:56 schrieb Arnd Bergmann via samba-technical: > On Tue, Dec 19, 2017 at 11:33 AM, Stefan Metzmacher wrote: >> Hi Arnd, >> >>> diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig >>> index 500fd69fb58b..3bfc55c08bef 100644 >>> --- a/fs/cifs/Kconfig >>> +++

Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Stefan Metzmacher
Am 19.12.2017 um 11:56 schrieb Arnd Bergmann via samba-technical: > On Tue, Dec 19, 2017 at 11:33 AM, Stefan Metzmacher wrote: >> Hi Arnd, >> >>> diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig >>> index 500fd69fb58b..3bfc55c08bef 100644 >>> --- a/fs/cifs/Kconfig >>> +++ b/fs/cifs/Kconfig >>> @@

Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Arnd Bergmann
On Tue, Dec 19, 2017 at 11:33 AM, Stefan Metzmacher wrote: > Hi Arnd, > >> diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig >> index 500fd69fb58b..3bfc55c08bef 100644 >> --- a/fs/cifs/Kconfig >> +++ b/fs/cifs/Kconfig >> @@ -199,6 +199,7 @@ config CIFS_SMB311 >> config

Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Arnd Bergmann
On Tue, Dec 19, 2017 at 11:33 AM, Stefan Metzmacher wrote: > Hi Arnd, > >> diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig >> index 500fd69fb58b..3bfc55c08bef 100644 >> --- a/fs/cifs/Kconfig >> +++ b/fs/cifs/Kconfig >> @@ -199,6 +199,7 @@ config CIFS_SMB311 >> config CIFS_SMB_DIRECT >> bool

Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Stefan Metzmacher
Hi Arnd, > diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig > index 500fd69fb58b..3bfc55c08bef 100644 > --- a/fs/cifs/Kconfig > +++ b/fs/cifs/Kconfig > @@ -199,6 +199,7 @@ config CIFS_SMB311 > config CIFS_SMB_DIRECT > bool "SMB Direct support (Experimental)" > depends on CIFS &&

Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Stefan Metzmacher
Hi Arnd, > diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig > index 500fd69fb58b..3bfc55c08bef 100644 > --- a/fs/cifs/Kconfig > +++ b/fs/cifs/Kconfig > @@ -199,6 +199,7 @@ config CIFS_SMB311 > config CIFS_SMB_DIRECT > bool "SMB Direct support (Experimental)" > depends on CIFS &&

[PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Arnd Bergmann
A built-in SMB file system cannot link against a modular infiniband core module: fs/cifs/smbdirect.o: In function `smbd_destroy_rdma_work': smbdirect.c:(.text+0x28e3): undefined reference to `ib_drain_qp' smbdirect.c:(.text+0x2915): undefined reference to `rdma_destroy_qp'

[PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m

2017-12-19 Thread Arnd Bergmann
A built-in SMB file system cannot link against a modular infiniband core module: fs/cifs/smbdirect.o: In function `smbd_destroy_rdma_work': smbdirect.c:(.text+0x28e3): undefined reference to `ib_drain_qp' smbdirect.c:(.text+0x2915): undefined reference to `rdma_destroy_qp'