Re: [PATCH] CMA: correct unlock target

2014-05-29 Thread Marek Szyprowski
Hello, On 2014-05-29 16:56, Laura Abbott wrote: On 5/29/2014 12:34 AM, Marek Szyprowski wrote: > Hello, > > On 2014-05-29 08:29, Joonsoo Kim wrote: >> 'cma: Remove potential deadlock situation' introduces per cma area mutex >> for bitmap management. It is good, but there is one mistake. When we

Re: [PATCH] CMA: correct unlock target

2014-05-29 Thread Michal Nazarewicz
On Thu, May 29 2014, Joonsoo Kim wrote: > 'cma: Remove potential deadlock situation' introduces per cma area mutex > for bitmap management. It is good, but there is one mistake. When we > can't find appropriate area in bitmap, we release cma_mutex global lock > rather than cma->lock and this is a

Re: [PATCH] CMA: correct unlock target

2014-05-29 Thread David Rientjes
On Thu, 29 May 2014, Joonsoo Kim wrote: > 'cma: Remove potential deadlock situation' introduces per cma area mutex > for bitmap management. It is good, but there is one mistake. When we > can't find appropriate area in bitmap, we release cma_mutex global lock > rather than cma->lock and this is a

Re: [PATCH] CMA: correct unlock target

2014-05-29 Thread Laura Abbott
On 5/29/2014 12:34 AM, Marek Szyprowski wrote: > Hello, > > On 2014-05-29 08:29, Joonsoo Kim wrote: >> 'cma: Remove potential deadlock situation' introduces per cma area mutex >> for bitmap management. It is good, but there is one mistake. When we >> can't find appropriate area in bitmap, we relea

Re: [PATCH] CMA: correct unlock target

2014-05-29 Thread Marek Szyprowski
Hello, On 2014-05-29 08:29, Joonsoo Kim wrote: 'cma: Remove potential deadlock situation' introduces per cma area mutex for bitmap management. It is good, but there is one mistake. When we can't find appropriate area in bitmap, we release cma_mutex global lock rather than cma->lock and this is a

[PATCH] CMA: correct unlock target

2014-05-28 Thread Joonsoo Kim
'cma: Remove potential deadlock situation' introduces per cma area mutex for bitmap management. It is good, but there is one mistake. When we can't find appropriate area in bitmap, we release cma_mutex global lock rather than cma->lock and this is a bug. So fix it. Signed-off-by: Joonsoo Kim dif