Re: [PATCH] Clean up on_each_cpu: should not fail, should not have "retry" arg

On Thu, 19 Jul 2007 13:07:14 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > Finally, either slub.c's flush_all() can be called with interrupts > disabled on UP, or the #ifdef is gratuitous. I assumed the latter. Correct. flush_all() is always called with interrupts disabled. So its gratuitous.

[PATCH] Clean up on_each_cpu: should not fail, should not have "retry" arg

Summary: on_each_cpu() should return void, since callers can't do anything useful with an error. It should not have the "retry" arg since it's of questionable utility and simply adds to Kernel Trivial Persuit. Only Alpha and PA-RISC use the "retry" arg to smp_call_function (it makes them return -