Re: [PATCH] Cleanup elevator_ops->trim function

2007-07-19 Thread Jens Axboe
On Thu, Jul 19 2007, Pavel Emelyanov wrote: > The elevator_ops's member "trim" is declared and called not like > all the other ones. Was this deliberate? It's not a elevator action like the others, it's not called during request handling, only for shutdown. So the different naming is actually ok,

[PATCH] Cleanup elevator_ops->trim function

2007-07-19 Thread Pavel Emelyanov
The elevator_ops's member "trim" is declared and called not like all the other ones. Was this deliberate? Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- block/as-iosched.c |2 +- block/cfq-iosched.c |2 +- block/elevator.c |4 ++-- include/linux/elevator.h |

[PATCH] Cleanup elevator_ops-trim function

2007-07-19 Thread Pavel Emelyanov
The elevator_ops's member trim is declared and called not like all the other ones. Was this deliberate? Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- block/as-iosched.c |2 +- block/cfq-iosched.c |2 +- block/elevator.c |4 ++-- include/linux/elevator.h |

Re: [PATCH] Cleanup elevator_ops-trim function

2007-07-19 Thread Jens Axboe
On Thu, Jul 19 2007, Pavel Emelyanov wrote: The elevator_ops's member trim is declared and called not like all the other ones. Was this deliberate? It's not a elevator action like the others, it's not called during request handling, only for shutdown. So the different naming is actually ok, it