Re: [PATCH] Common compat_sys_sysinfo (v2)

On Mon, 8 Jan 2007 06:54:26 +0100 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > > > People have complined before that this adds a whole stack frame to the > > "normal" syscall path.  Personally I don't care, but it has been > > mentioned. > > It might be a concern for something like 'read' which is ca

Re: [PATCH] Common compat_sys_sysinfo (v2)

On Monday 08 January 2007 00:43, Stephen Rothwell wrote: > > +asmlinkage long sys_sysinfo(struct sysinfo __user *info) > > +{ > > + struct sysinfo val; > > + > > + do_sysinfo(&val); > > > > - out: > >   if (copy_to_user(info, &val, sizeof(struct sysinfo))) > >   return -EFAU

Re: [PATCH] Common compat_sys_sysinfo (v2)

Hi Kyle, Looks good. Just one nit and one comment. On Sun, 7 Jan 2007 10:40:45 -0500 Kyle McMartin <[EMAIL PROTECTED]> wrote: > > diff --git a/kernel/compat.c b/kernel/compat.c > index 6952dd0..cebb4c2 100644 > --- a/kernel/compat.c > +++ b/kernel/compat.c . . . > + __put_user (s.upti

[PATCH] Common compat_sys_sysinfo (v2)

diff --git a/arch/ia64/ia32/ia32_entry.S b/arch/ia64/ia32/ia32_entry.S index a32cd59..0a76de0 100644 --- a/arch/ia64/ia32/ia32_entry.S +++ b/arch/ia64/ia32/ia32_entry.S @@ -326,7 +326,7 @@ ia32_syscall_table: data8 sys_ni_syscall data8 compat_sys_wait4 data8 sys_swapoff