Re: [PATCH] Crypto: gf128mul : fixed a parentheses coding style issue

2014-10-13 Thread Joe Perches
On Mon, 2014-10-13 at 21:52 +0100, Michael Roocroft wrote: > I fully intend to making more meaningful contributions > when my confidence in writing C is better than it is at the moment. I'll > concentrate > on making any changes to staging whilst I learn and get to grips with git, and > continue t

Re: [PATCH] Crypto: gf128mul : fixed a parentheses coding style issue

2014-10-13 Thread Michael Roocroft
On 10/13/14 21:15, Joe Perches wrote: On Mon, 2014-10-13 at 21:12 +0100, Michael Roocroft wrote: On 10/13/14 00:01, Joe Perches wrote: On Sun, 2014-10-12 at 21:49 +0100, Mike Roocroft wrote: Fixed a coding style issue. [] diff --git a/crypto/gf128mul.c b/crypto/gf128mul.c [] @@ -97,7 +97,7

Re: [PATCH] Crypto: gf128mul : fixed a parentheses coding style issue

2014-10-13 Thread Joe Perches
On Mon, 2014-10-13 at 21:12 +0100, Michael Roocroft wrote: > On 10/13/14 00:01, Joe Perches wrote: > > On Sun, 2014-10-12 at 21:49 +0100, Mike Roocroft wrote: > >> Fixed a coding style issue. > > [] > >> diff --git a/crypto/gf128mul.c b/crypto/gf128mul.c > > [] > >> @@ -97,7 +97,7 @@ > >> the

Re: [PATCH] Crypto: gf128mul : fixed a parentheses coding style issue

2014-10-13 Thread Michael Roocroft
On 10/13/14 00:01, Joe Perches wrote: On Sun, 2014-10-12 at 21:49 +0100, Mike Roocroft wrote: Fixed a coding style issue. [] diff --git a/crypto/gf128mul.c b/crypto/gf128mul.c [] @@ -97,7 +97,7 @@ the table above */ -#define xx(p, q) 0x##p##q +#define xx(p, q) (0x##p##q)

Re: [PATCH] Crypto: gf128mul : fixed a parentheses coding style issue

2014-10-12 Thread Joe Perches
On Sun, 2014-10-12 at 21:49 +0100, Mike Roocroft wrote: > Fixed a coding style issue. [] > diff --git a/crypto/gf128mul.c b/crypto/gf128mul.c [] > @@ -97,7 +97,7 @@ > the table above > */ > > -#define xx(p, q) 0x##p##q > +#define xx(p, q) (0x##p##q) > > #define xda_bbe(i) ( \ >

[PATCH] Crypto: gf128mul : fixed a parentheses coding style issue

2014-10-12 Thread Mike Roocroft
Fixed a coding style issue. Signed-off-by: Mike Roocroft --- crypto/gf128mul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/gf128mul.c b/crypto/gf128mul.c index 5276607..b143d84 100644 --- a/crypto/gf128mul.c +++ b/crypto/gf128mul.c @@ -97,7 +97,7 @@ the table

[PATCH] Crypto: gf128mul : fixed a parentheses coding style issue

2014-10-05 Thread Mike Roocroft
Fixed a coding style issue. Signed-off-by: Mike Roocroft --- crypto/gf128mul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/gf128mul.c b/crypto/gf128mul.c index 5276607..b143d84 100644 --- a/crypto/gf128mul.c +++ b/crypto/gf128mul.c @@ -97,7 +97,7 @@ the table