Re: [PATCH] DM9000 network driver

2005-03-18 Thread Sascha Hauer
On Fri, Mar 18, 2005 at 04:58:17PM +, Ben Dooks wrote: > > As the person who did the updates to Sacha's > original driver port, he should have really checked > with me for up-to-date version first, and to collect > a Signed-off-by: line. > Sorry, Ben. Of course I should have asked you first,

Re: [PATCH] DM9000 network driver

2005-03-18 Thread Ben Dooks
On Fri, Mar 18, 2005 at 04:21:30PM +, Alan Cox wrote: > On Gwe, 2005-03-18 at 13:31, Sascha Hauer wrote: > > Hello all, > > > > This patch adds support for the davicom dm9000 network driver. The > > dm9000 is found on some embedded arm boards such as the pimx1 or the > > scb9328. > > Unless I

Re: [PATCH] DM9000 network driver

2005-03-18 Thread Alan Cox
On Gwe, 2005-03-18 at 13:31, Sascha Hauer wrote: > Hello all, > > This patch adds support for the davicom dm9000 network driver. The > dm9000 is found on some embedded arm boards such as the pimx1 or the > scb9328. Unless I'm missing something its just yet another NE2000 (ie 8390) clone and can u

Re: [PATCH] DM9000 network driver

2005-03-18 Thread linux-os
On Fri, 18 Mar 2005 [EMAIL PROTECTED] wrote: On Fri, Mar 18, 2005 at 08:41:52PM +0530, Hong Kong Phoey wrote: Sacrificing readibility a little bit, you could do something useful. Instead of those ugly switch statements you could define function pointer arrays and call appropriate function switch(fo

Re: [PATCH] DM9000 network driver

2005-03-18 Thread Dmitry Torokhov
On Fri, 18 Mar 2005 10:25:54 -0500, Lennart Sorensen <[EMAIL PROTECTED]> wrote: > On Fri, Mar 18, 2005 at 08:41:52PM +0530, Hong Kong Phoey wrote: > > Sacrificing readibility a little bit, you could do something useful. > > Instead of those ugly switch statements you could define function > > point

Re: [PATCH] DM9000 network driver

2005-03-18 Thread John W. Linville
On Fri, Mar 18, 2005 at 10:25:54AM -0500, Lennart Sorensen wrote: > On Fri, Mar 18, 2005 at 08:41:52PM +0530, Hong Kong Phoey wrote: > > switch(foo) { > > > > case 1: > > f1(); > > case2 : > > f2(); > > }; > > > > could well become > > > > void (*func)[] = { f1, f2

Re: [PATCH] DM9000 network driver

2005-03-18 Thread Lennart Sorensen
On Fri, Mar 18, 2005 at 08:41:52PM +0530, Hong Kong Phoey wrote: > Sacrificing readibility a little bit, you could do something useful. > Instead of those ugly switch statements you could define function > pointer arrays and call appropriate function > > switch(foo) { > > case 1: >

Re: [PATCH] DM9000 network driver

2005-03-18 Thread Hong Kong Phoey
Sacrificing readibility a little bit, you could do something useful. Instead of those ugly switch statements you could define function pointer arrays and call appropriate function switch(foo) { case 1: f1(); case2 : f2(); }; could well become void (*func)[] = { f1,

[PATCH] DM9000 network driver

2005-03-18 Thread Sascha Hauer
Hello all, This patch adds support for the davicom dm9000 network driver. The dm9000 is found on some embedded arm boards such as the pimx1 or the scb9328. Sascha Hauer Signed-off-by: Sascha Hauer <[EMAIL PROTECTED]> diff -urN linux-2.6.11/drivers/net/Kconfig linux-2.6.11-work/drivers/net/Kcon